Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to python 3.11; upgrade redis library; upgrade databases #490

Merged
merged 12 commits into from
Sep 21, 2023
Merged

chore: upgrade to python 3.11; upgrade redis library; upgrade databases #490

merged 12 commits into from
Sep 21, 2023

Conversation

7mochi
Copy link
Contributor

@7mochi 7mochi commented Sep 13, 2023 •
edited
Loading

Describe your changes

Related Issues / Projects

Checklist

  • I've manually tested my code
    • Make install
    • Make install-dev
    • Make run
    • Login
    • Commands
      • Help
      • Roll
      • API Key
      • Block/Unblock
      • Reconnect
      • Maplink
      • Recent
      • Top
      • With
      • Request
      • Requests
      • Map Rank/Unrank/Love Map/Set
      • Notes
      • Add note
      • Server
      • Menu
      • Addpriv
      • Rmpriv
      • Givedonator
      • Stealth
      • Switch server
      • Alert
      • Alert user
    • Submit plays
      • vn!std
      • vn!taiko
      • vn!ctb
      • vn!ctb
      • rx!std
      • rx!taiko
      • rx!ctb
      • ap!std
      • ap!ctb
      • ap!mania
    • Multiplayer
  • The changes pass pre-commit checks (make lint)
  • The changes follow coding style

@7mochi 7mochi added the enhancement New feature or request label Sep 13, 2023
@7mochi 7mochi self-assigned this Sep 13, 2023
@NiceAesth
Copy link
Contributor

I would hope you didn't do this manually but looking at the fact you didn't change pyupgrade from 37-plus to 311-plus does not inspire confidence

@7mochi
Copy link
Contributor Author

7mochi commented Sep 13, 2023

I would hope you didn't do this manually but looking at the fact you didn't change pyupgrade from 37-plus to 311-plus does not inspire confidence

I just modified the Pipfile and let the lock file regenerate, is there anything i forgot to modify or should do differently?

@NiceAesth
Copy link
Contributor

I would hope you didn't do this manually but looking at the fact you didn't change pyupgrade from 37-plus to 311-plus does not inspire confidence

I just modified the Pipfile and let the lock file regenerate, is there anything i forgot to modify or should do differently?

should update pre-commit pyupgrade args to do 311

@NiceAesth
Copy link
Contributor

also, this definitely needs to be tested

@7mochi
Copy link
Contributor Author

7mochi commented Sep 17, 2023

I would hope you didn't do this manually but looking at the fact you didn't change pyupgrade from 37-plus to 311-plus does not inspire confidence

I just modified the Pipfile and let the lock file regenerate, is there anything i forgot to modify or should do differently?

should update pre-commit pyupgrade args to do 311

done, i need testers :3

@NiceAesth
Copy link
Contributor

#493 will change deps

@NiceAesth
Copy link
Contributor

can you fix conflicts? want to get this merged. @7mochi

also, python 3.12 is very close to releasing as well. should be looking into that after this PR (especially typing changes)

@NiceAesth NiceAesth mentioned this pull request Sep 21, 2023
Closed
3 tasks
@NiceAesth NiceAesth changed the title chore: Upgrade to python 3.11 chore: upgrade to python 3.11; upgrade redis library; upgrade databases Sep 21, 2023
NiceAesth
NiceAesth approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@NiceAesth NiceAesth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dismissing

NiceAesth
NiceAesth requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@NiceAesth NiceAesth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes need to be tested further with updated dependencies

NiceAesth
NiceAesth approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work fine. further testing is welcomed.

loc balooned up due to auto-formatting bump to py3.11

@NiceAesth NiceAesth merged commit 176899d into master Sep 21, 2023
1 check passed
@NiceAesth NiceAesth deleted the upgrade-py-3.11 branch September 21, 2023 15:53
@cmyui
Copy link
Member

cmyui commented Sep 21, 2023

🔥 nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiceAesth NiceAesth NiceAesth approved these changes

@cmyui cmyui Awaiting requested review from cmyui cmyui is a code owner

@skrungly skrungly Awaiting requested review from skrungly

@tsunyoku tsunyoku Awaiting requested review from tsunyoku tsunyoku is a code owner

Assignees

@7mochi 7mochi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7mochi @NiceAesth @cmyui