Fix mypy discovery & all type errors across source #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyui
commented
Sep 24, 2023
| @@ -1,19 +1,28 @@ | |||
| [mypy] | |||
| strict = True | |||
| disallow_untyped_calls = False | |||
| exclude = ["tests"] | |||
There was a problem hiding this comment.
turns out, this is a regex field and was making mypy avoid running on most source files.
mypy was reporting to be running on 3 source files; after these adjustments, it is reporting to run on 70 source files, and pointed out all the additional issues fixed in this PR.
cmyui
commented
Sep 24, 2023
| if meta is None: | ||
| meta = {} | ||
| data = {"status": "success", "data": content, "meta": meta} | ||
| return json.ORJSONResponse(data, status_code, headers) | ||
| # XXX:HACK to make typing work | ||
| return cast(Success[T], json.ORJSONResponse(data, status_code, headers)) |
There was a problem hiding this comment.
@tsunyoku rate the based hacks
cmyui
commented
Sep 24, 2023
| @@ -22,7 +22,7 @@ | |||
| import app.settings | |||
| import app.state | |||
| import app.utils | |||
| from app.api import api_router | |||
| from app.api import api_router # type: ignore[attr-defined] | |||
There was a problem hiding this comment.
i think this is a result of a circular import, but i'm not 100% sure
cmyui
commented
Sep 24, 2023
| if not ( | ||
| ctx.player in match.refs | ||
| or ctx.player.priv & Privileges.TOURNEY_MANAGER | ||
| or f is mp_help.__wrapped__ # type: ignore[attr-defined] |
cmyui
requested review from
skrungly,
NiceAesth,
tsunyoku and
7mochi
as code owners
cmyui
added
bug
cmyui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related Issues / Projects
Checklist
make lint)