Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update safe name with name on !changename command #539

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: update safe name with name on !changename command #539

merged 2 commits into from
Oct 6, 2023

Conversation

foksurek
Copy link
Contributor

@foksurek foksurek commented Oct 6, 2023 •
edited
Loading

Describe your changes

This PR introduces significant change to resolve specific issue. The main change is:

  • Adding 'safe_name' Field Update: I'm introducing an update to the safe_name field when updating the name field. This resolves the issue where the 'safe_name' field was not correctly updated when using the '!changename' command.

Checklist

  • I've manually tested my code
  • The changes follow coding style

NiceAesth

This comment was marked as outdated.

Sign in to view

NiceAesth
NiceAesth previously requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe_name needs to be added to playerupdatefields

@foksurek foksurek requested a review from NiceAesth October 6, 2023 17:58
cmyui
cmyui approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@cmyui cmyui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! :)

@cmyui cmyui merged commit 0281dbb into osuAkatsuki:master Oct 6, 2023
3 checks passed
@cmyui cmyui added the bug Something isn't working label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyui cmyui cmyui approved these changes

@skrungly skrungly Awaiting requested review from skrungly

@tsunyoku tsunyoku Awaiting requested review from tsunyoku tsunyoku is a code owner

@7mochi 7mochi Awaiting requested review from 7mochi 7mochi is a code owner

@NiceAesth NiceAesth Awaiting requested review from NiceAesth NiceAesth is a code owner

Assignees

@foksurek foksurek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foksurek @NiceAesth @cmyui