fix: catch pp wrong due to both acc and judgements specified #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minisbett
requested review from
cmyui,
skrungly,
NiceAesth,
tsunyoku and
7mochi
as code owners
cmyui
reviewed
Feb 19, 2024
|
bug fixes like this are really good candidates for adding unit tests to cover imo |
NiceAesth
changed the title
cmyui
reviewed
Feb 19, 2024
cmyui
reviewed
Feb 26, 2024
for more information, see https://pre-commit.ci
cmyui
previously approved these changes
Feb 26, 2024
cmyui
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
PP breaks on catch if both the accuracy and the 50s are specified. In VC we argued the best way to solve this is raising an exception in the usecase, and dropping specifying acc where possible, since it's a useless info.
This PR fixes catch PP, meaning bancho.py hosters will need to re-calculate all PP. Before doing this, I'd suggest looking into #573, as it improves the functionality of the recalc script and might be significant with this change.
Checklist