Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing country field to get_map_scores #649

Merged
merged 3 commits into from
Apr 11, 2024
Merged

add missing country field to get_map_scores #649

merged 3 commits into from
Apr 11, 2024

Conversation

HorizonCode
Copy link
Contributor

@HorizonCode HorizonCode commented Mar 15, 2024 •
edited by tsunyoku
Loading

Describe your changes

  • adds player_country to /v1/get_map_scores

Checklist

  • I've manually tested my code

@HorizonCode HorizonCode mentioned this pull request Apr 4, 2024
Closed
NiceAesth
NiceAesth approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally fine with it waiting to hear on at least one more person

NiceAesth
NiceAesth previously requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency

app/api/v1/api.py Outdated Show resolved Hide resolved
@tsunyoku tsunyoku requested a review from NiceAesth April 11, 2024 15:49
@tsunyoku tsunyoku merged commit a351fd5 into osuAkatsuki:master Apr 11, 2024
5 checks passed
@HorizonCode HorizonCode deleted the country branch June 18, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunyoku tsunyoku tsunyoku approved these changes

@cmyui cmyui Awaiting requested review from cmyui cmyui is a code owner

@7mochi 7mochi Awaiting requested review from 7mochi 7mochi is a code owner

@NiceAesth NiceAesth Awaiting requested review from NiceAesth NiceAesth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HorizonCode @NiceAesth @tsunyoku