Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that provided MySQL and Redis passwords are URL-Safe #664

Merged
merged 2 commits into from
May 21, 2024

Conversation

def750
Copy link
Contributor

@def750 def750 commented May 20, 2024

Describe your changes

Added urlib parse to redis and MySQL passwords, to ensure that passwords are URL-Safe without need to escape special characters

Related Issues / Projects

Checklist

  • I've manually tested my code

@cmyui
Copy link
Member

cmyui commented May 21, 2024

thanks for the fix!

hmm, i see at the moment we just construct the dsn's inline in settings now: https://github.com/def750/gaug/blob/a6403bfb3a772feeb5290ac9a90278878e575029/app/settings.py#L22

we should probably have create_dsn() functions for redis & mysql, with quoting implemented there, such that more code could benefit from this

@cmyui cmyui added the bug Something isn't working label May 21, 2024
@cmyui cmyui merged commit 9650fdd into osuAkatsuki:master May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants