Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of docker-compose with docker compose. #668

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

RealistikDash
Copy link
Contributor

@RealistikDash RealistikDash commented Jun 26, 2024

Describe your changes

The use of docker-compose has been officially deprecated in favour of docker compose (part of the official Docker package). On newer distros, docker-compose no longer works.

Related Issues / Projects

Checklist

  • I've manually tested my code

@tsunyoku
Copy link
Contributor

we probably want to change the setup instructions to not use apt for docker as a pre-requisite. from experience, some distros/vendors/etc. do not provide a new enough docker version for us to use

@tsunyoku
Copy link
Contributor

another thing, WSL users should be using docker desktop and not installing docker inside of their WSL - something else we should make clear

unrelated to this though

@NiceAesth
Copy link
Contributor

we probably want to change the setup instructions to not use apt for docker as a pre-requisite. from experience, some distros/vendors/etc. do not provide a new enough docker version for us to use

could probably just link them to the docker documentation and call it a day, it has instructions on how to use the docker install script

@marcandreher
Copy link

I have the same issue docker-compose doesn't work anymore, for my instance I switched that. On Ubuntu 24.04 docker-compose is not working anymore

@cmyui
Copy link
Member

cmyui commented Jun 26, 2024

could probably just link them to the docker documentation and call it a day

+1 to keep the instructions up to date

@cmyui
Copy link
Member

cmyui commented Jun 26, 2024

If this breaks someone's instance due to an old install, what's the fix for them? (is there a simple command i can copy/pasta?)

@NiceAesth
Copy link
Contributor

If this breaks someone's instance due to an old install, what's the fix for them? (is there a simple command i can copy/pasta?)

hmm, best option would be to get them to update their docker install but

https://docs.docker.com/compose/install/linux/

it is also possible to 'retrofit' the compose plugin into an existing docker install 😅 (keep in mind that most recent versions come with it pre-installed)

@cmyui
Copy link
Member

cmyui commented Jun 27, 2024

hmm, best option would be to get them to update their docker install but

https://docs.docker.com/compose/install/linux/

it is also possible to 'retrofit' the compose plugin into an existing docker install 😅 (keep in mind that most recent versions come with it pre-installed)

Sweet, thanks for that -- works for me

@cmyui cmyui enabled auto-merge (squash) June 27, 2024 22:36
@cmyui
Copy link
Member

cmyui commented Jun 27, 2024

Thanks for the PR!

@cmyui cmyui merged commit af126d9 into osuAkatsuki:master Jun 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants