Thumbnail chrome driver compatibility fix #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
tsunyoku
suggested changes
Dec 24, 2024
There was a problem hiding this comment.
Don't really like how this forces me to use a production APP_ENV if I want to use a local beatmaps-service... We should probably be running the right stack if testing locally to begin with, but if we're really going to do this anyways then I'd rather have some env var that dictates an "API vendor" or similar to dictate what URLs we use. This just feels like an ugly solution.
Can we not PR the fix separately and get that in and worry about the dev environment later?
lenforiee
changed the title
|
fair enough, removed local dev stuff in 675fbbc |
tsunyoku
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.