Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make package.json#main point to a correct file #44

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Jan 22, 2024

This was causing environments that don't support conditional exports (Jest, eslint-plugin-import, ...) to break, being a blocker at graphql/graphiql#3475

Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: 3f4e78f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astrojs-compiler-sync Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Jan 22, 2024

Not sure what kind of changeset would be appropriate for this kind of change. Do you consider this as a breaking change?

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!
I believe this is a patch because it was previously pointing to a file that didn't exist.

@ota-meshi ota-meshi merged commit 59bdc69 into ota-meshi:main Jan 22, 2024
3 of 4 checks passed
@XiNiHa XiNiHa deleted the fix/package-json-main branch January 22, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants