Add no-super-linear-backtracking rule
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements one of the solutions from #159. It's a very simple and limited detection method but it should be a good start. However, the limitations of the detection method allow it to fix some of the reported cases which is a valuable feature.
I updated some dependencies with CVEs in one of my projects today. One of them was this. This case of ReDoS could have been automatically detected and even fixed using this rule.
I went through some more ReDoS CVEs on snyk and a lot of them were detectable using this rule. Some even fixable.
I definitely want this rule for v1.0.
I also want to add another rule to detect ReDoS not caused by backtracking after this rule got merged.