Skip to content

Commit

Permalink
Consolidate mapperclient packages (#257)
Browse files Browse the repository at this point in the history
  • Loading branch information
orishavit authored Dec 11, 2024
1 parent f16b423 commit 17fd9dc
Show file tree
Hide file tree
Showing 27 changed files with 337 additions and 430 deletions.
2 changes: 2 additions & 0 deletions build/mapper.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ RUN go test ./mapper/...
FROM test as builder
ARG TARGETOS
ARG TARGETARCH

RUN echo "Building for $TARGETOS/$TARGETARCH - Running on $(uname -m)"
RUN CGO_ENABLED=0 GOOS=$TARGETOS GOARCH=$TARGETARCH go build -trimpath -o /main ./mapper/cmd

# add version file
Expand Down
4 changes: 2 additions & 2 deletions src/kafka-watcher/cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/otterize/intents-operator/src/shared/telemetries/telemetrysender"
"github.com/otterize/network-mapper/src/kafka-watcher/pkg/config"
logwatcher2 "github.com/otterize/network-mapper/src/kafka-watcher/pkg/logwatcher"
"github.com/otterize/network-mapper/src/kafka-watcher/pkg/mapperclient"
"github.com/otterize/network-mapper/src/mapperclient"
sharedconfig "github.com/otterize/network-mapper/src/shared/config"
"github.com/otterize/network-mapper/src/shared/version"
"github.com/sirupsen/logrus"
Expand Down Expand Up @@ -46,7 +46,7 @@ func main() {

ctrl.SetLogger(logrusr.New(logrus.StandardLogger()))

mapperClient := mapperclient.NewMapperClient(viper.GetString(sharedconfig.MapperApiUrlKey))
mapperClient := mapperclient.New(viper.GetString(sharedconfig.MapperApiUrlKey))

mode := viper.GetString(config.KafkaLogReadModeKey)

Expand Down
4 changes: 2 additions & 2 deletions src/kafka-watcher/pkg/logwatcher/filewatcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"
"github.com/nxadm/tail"
"github.com/otterize/network-mapper/src/kafka-watcher/pkg/config"
"github.com/otterize/network-mapper/src/kafka-watcher/pkg/mapperclient"
"github.com/otterize/network-mapper/src/mapperclient"
"github.com/sirupsen/logrus"
"github.com/spf13/viper"
"io"
Expand All @@ -20,7 +20,7 @@ type LogFileWatcher struct {
server types.NamespacedName
}

func NewLogFileWatcher(mapperClient mapperclient.MapperClient, authzFilePath string, server types.NamespacedName) (*LogFileWatcher, error) {
func NewLogFileWatcher(mapperClient *mapperclient.Client, authzFilePath string, server types.NamespacedName) (*LogFileWatcher, error) {
w := &LogFileWatcher{
baseWatcher: baseWatcher{
mu: sync.Mutex{},
Expand Down
4 changes: 2 additions & 2 deletions src/kafka-watcher/pkg/logwatcher/kubeneteslogwatcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"context"
"github.com/otterize/intents-operator/src/shared/errors"
"github.com/otterize/network-mapper/src/kafka-watcher/pkg/config"
"github.com/otterize/network-mapper/src/kafka-watcher/pkg/mapperclient"
"github.com/otterize/network-mapper/src/mapperclient"
"github.com/sirupsen/logrus"
"github.com/spf13/viper"
"golang.org/x/exp/slices"
Expand All @@ -28,7 +28,7 @@ type KubernetesLogWatcher struct {
kafkaServers []types.NamespacedName
}

func NewKubernetesLogWatcher(mapperClient mapperclient.MapperClient, kafkaServers []types.NamespacedName) (*KubernetesLogWatcher, error) {
func NewKubernetesLogWatcher(mapperClient *mapperclient.Client, kafkaServers []types.NamespacedName) (*KubernetesLogWatcher, error) {
conf, err := rest.InClusterConfig()

if err != nil && !errors.Is(err, rest.ErrNotInCluster) {
Expand Down
10 changes: 5 additions & 5 deletions src/kafka-watcher/pkg/logwatcher/watcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"context"
"errors"
"github.com/oriser/regroup"
mapperclient2 "github.com/otterize/network-mapper/src/kafka-watcher/pkg/mapperclient"
"github.com/otterize/network-mapper/src/kafka-watcher/pkg/prometheus"
"github.com/otterize/network-mapper/src/mapperclient"
"github.com/samber/lo"
"github.com/sirupsen/logrus"
"k8s.io/apimachinery/pkg/types"
Expand Down Expand Up @@ -37,7 +37,7 @@ type Watcher interface {
type baseWatcher struct {
mu sync.Mutex
seen SeenRecordsStore
mapperClient mapperclient2.MapperClient
mapperClient *mapperclient.Client
}

func (b *baseWatcher) flush() SeenRecordsStore {
Expand All @@ -61,8 +61,8 @@ func (b *baseWatcher) reportResults(ctx context.Context) error {
logrus.Infof("Reporting %d records", cRecords)
prometheus.IncrementKafkaTopicReports(cRecords)

results := lo.MapToSlice(records, func(r AuthorizerRecord, t time.Time) mapperclient2.KafkaMapperResult {
return mapperclient2.KafkaMapperResult{
results := lo.MapToSlice(records, func(r AuthorizerRecord, t time.Time) mapperclient.KafkaMapperResult {
return mapperclient.KafkaMapperResult{
SrcIp: r.Host,
ServerPodName: r.Server.Name,
ServerNamespace: r.Server.Namespace,
Expand All @@ -72,7 +72,7 @@ func (b *baseWatcher) reportResults(ctx context.Context) error {
}
})

return b.mapperClient.ReportKafkaMapperResults(ctx, mapperclient2.KafkaMapperResults{Results: results})
return b.mapperClient.ReportKafkaMapperResults(ctx, mapperclient.KafkaMapperResults{Results: results})
}

func (b *baseWatcher) processLogRecord(kafkaServer types.NamespacedName, record string) {
Expand Down
35 changes: 0 additions & 35 deletions src/kafka-watcher/pkg/mapperclient/client.go

This file was deleted.

4 changes: 0 additions & 4 deletions src/kafka-watcher/pkg/mapperclient/generate.go

This file was deleted.

132 changes: 0 additions & 132 deletions src/kafka-watcher/pkg/mapperclient/generated.go

This file was deleted.

7 changes: 0 additions & 7 deletions src/kafka-watcher/pkg/mapperclient/genqlient.graphql

This file was deleted.

12 changes: 0 additions & 12 deletions src/kafka-watcher/pkg/mapperclient/genqlient.yaml

This file was deleted.

64 changes: 0 additions & 64 deletions src/kafka-watcher/pkg/mapperclient/mockclient/mocks.go

This file was deleted.

Loading

0 comments on commit 17fd9dc

Please sign in to comment.