refactor: remove isActive length check

[pscott]

Describe your changes

Reorder the requires and remove a needless check in setAdmins.

Types of changes

• Optimizatiooooon

[pscott]

Unsure why the ci is failing :(

[rahulrumalla]

Unsure why the ci is failing :(

I think the CI didn't pick up the env vars correctly. Wondering if this is because the PR is coming in from a fork 🤔 Will look into it..

[rahulrumalla]

Yeah, I was right.

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.
https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

I haven't looked into whether this is outdated, but if you're able to add these 2 GH secret to your fork's secrets, I think that could pass the CI

    DEPLOYER_PRIVATE_KEY: 
    ETHERSCAN_API_KEY: 

[pscott]

I added my ETHERSCAN_API_KEY, but for DEPLOYER_PRIVAT_KEY I input 0x1234. Will it work if you re-run the job? Or do I need an actual private key of a funded wallet on goerli?

[rahulrumalla]

I added my ETHERSCAN_API_KEY, but for DEPLOYER_PRIVAT_KEY I input 0x1234. Will it work if you re-run the job? Or do I need an actual private key of a funded wallet on goerli?

The PK is used to extract account addresses from it I blv. So needs a valid PK. Just use any valid PK, best if you're able to generate a new account or use a test account's PK. Lmk once you've added and I'll retrigger the buildto se if that helps

[pscott]

done :)