-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding compatibillity to older otb version #8
base: master
Are you sure you want to change the base?
Conversation
- Changed OtbWriter.cs vi.BuildNumber now increments - OTB Major version are saved according to clients.xml in Remeres Map Editor. Version = 1 to version <=792, version = 2 to 800 to 811 and version = 3 on later versions -Few changes in csprojs related to framework version
editting download link on README.md
Do u have a compiled version who works in 7.6 or 7.72? |
Yes! It is on my fork. Readme section "download" |
@Mignari Do you have any intention to merge it to master? |
This doesn't support 7.4 even though it does support 7.7. |
Did you find any incompatibility in my changes? |
I just tested it and it didn't work for 7.4 version which uses OTB version 1, your plugin seems to support only version 3 which started on version 7.6, items flags seems to be a bit different on versions prior to this, such as 7.4. |
Can you provide me the otb that you tested? I will check it and update as soon as possible |
Sure, here it is. |
Adding 7.x client, otb versions and spr, dat signatures
@danilopucci these might help with old known byte flags. https://github.com/opentibia/item-editor/blob/06580b4caacfe4ca1cb59eaafea531acf8988fac/client/item_type.cpp |
It will help for sure! I was looking on RME and TFS (items.cpp) to get the definitions and the flags, going to check your recomendations now |
The flags of .dat files on versions 7.x are bit different on their values. Using OTClient sources as a reference, I added the checkages on versions to load that correctly.
@WooXZerah Now things should work correctly. |
@danilopucci Mission accomplised! I tested and it worked perfectly, I'm glad I could help. @Mignari This deserve some attention, it should be merged to master. |
Changes in logic to find a compatible client. Previously there was only one OTB version to each Tibia version, with the new 7.x support there is more than one Tibia version to the same OTB version (710->730; 740->750 and 790 -> 792). With theese changes, now the logics consider a list instead of a single client, it reads the list and try to match it by the dat and spr signature
Fixing typo in version 780
what happened with this ? |
Hello Felipe, For now, you can use the compiled version on my branch. Please, let me know if you find any bug. |
I can't download it, |
Try from releases EDIT: I fixed the download link from my readme. Thanks |
hey danilopucci, do you know how to solve this problem on windows 11? |
Hey, I never tried to run it on win11. Did you tried to compile it? I think if you try to recompile it, the missing libraries or other kind of error will throw and we can investigate it. Or maybe just by recompiling it will fix the problem. (I do not have win11 installed) |
@danilopucci I'm looking to use your work on a 7.6 server (Goobers). |
@danilopucci I found your recompiled download. It works! I was actually hoping for an item editor to have an xml or sql export. Mainly so I can store all my items.otb information in tables to be shown on the website. Any thoughts on this? |
Hey @MightyGoob, I am not sure if I get it correctly, but maybe you would need something on your gameserver to update the database table with your items.otb. This way you will be 100% sure that your lastest version of items.otb will be reflected on your database table, with no dependencies on any other kind of file |
Theese commits adds compatibillity to older otb versions, for who wants to edit files from 7.4-7.92 servers.
I tried to follow all the coding patterns of project and I named the plugin as PluginZero, as One is from 8.0+ and so on.
Fixes issues #4 and #5 (seems to be duplicated)