Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compatibillity to older otb version #8

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

danilopucci
Copy link

@danilopucci danilopucci commented Apr 25, 2020

Theese commits adds compatibillity to older otb versions, for who wants to edit files from 7.4-7.92 servers.
I tried to follow all the coding patterns of project and I named the plugin as PluginZero, as One is from 8.0+ and so on.

Fixes issues #4 and #5 (seems to be duplicated)

danilopucci and others added 4 commits February 26, 2020 01:24
- Changed OtbWriter.cs vi.BuildNumber now increments
- OTB Major version are saved according to clients.xml in Remeres Map Editor. Version = 1 to version <=792, version = 2 to 800 to 811 and version = 3 on later versions 
-Few changes in csprojs related to framework version
editting download link on README.md
@p0t1nh0
Copy link

p0t1nh0 commented Dec 22, 2020

Do u have a compiled version who works in 7.6 or 7.72?

@danilopucci
Copy link
Author

Do u have a compiled version who works in 7.6 or 7.72?

Yes! It is on my fork. Readme section "download"

@danilopucci
Copy link
Author

@Mignari Do you have any intention to merge it to master?

@WooXZerah
Copy link

This doesn't support 7.4 even though it does support 7.7.

@danilopucci
Copy link
Author

This doesn't support 7.4 even though it does support 7.7.

Did you find any incompatibility in my changes?
Can you give any details about it?
Thanks

@WooXZerah
Copy link

Did you find any incompatibility in my changes?
Can you give any details about it?
Thanks

I just tested it and it didn't work for 7.4 version which uses OTB version 1, your plugin seems to support only version 3 which started on version 7.6, items flags seems to be a bit different on versions prior to this, such as 7.4.

@danilopucci
Copy link
Author

Did you find any incompatibility in my changes?
Can you give any details about it?
Thanks

I just tested it and it didn't work for 7.4 version which uses OTB version 1, your plugin seems to support only version 3 which started on version 7.6, items flags seems to be a bit different on versions prior to this, such as 7.4.

Can you provide me the otb that you tested? I will check it and update as soon as possible

@WooXZerah
Copy link

WooXZerah commented Feb 8, 2021

Can you provide me the otb that you tested? I will check it and update as soon as possible

Sure, here it is.
items.zip

Adding 7.x client, otb versions and spr, dat signatures
@WooXZerah
Copy link

@danilopucci
Copy link
Author

@danilopucci these might help with old known byte flags.

https://github.com/opentibia/item-editor/blob/06580b4caacfe4ca1cb59eaafea531acf8988fac/client/item_type.cpp
opentibia/item-editor@59028ea

It will help for sure! I was looking on RME and TFS (items.cpp) to get the definitions and the flags, going to check your recomendations now
Thank you

The flags of .dat files on versions 7.x are bit different on their values. Using OTClient sources as a reference, I added the checkages on versions to load that correctly.
@danilopucci
Copy link
Author

danilopucci commented Feb 21, 2021

@WooXZerah Now things should work correctly.
It looks that tibia.dat files on versions 7.x are very different, specially on version 7.4. On version 7.55 above things are more similar from each other but still has some differences.
I took as code reference this piece of OTClient code that consider and adjust the byte flags according to Tibia version properly. The reference that you provided me helped alot! Reading there I could track the differences of the byte flags and I remmembered that OTClient reads .dat files too, so I took a look there and found the code considerations of many versions to retro-compatibillity. Both references are equal on this point.
I tested it using Tibia.dat from Tibia7.4 client and the .otb that you provided me and it works fine.
Could you please test it?
Download here or by going on releases on my fork. ItemEditor_v0431.zip

@WooXZerah
Copy link

@danilopucci Mission accomplised! I tested and it worked perfectly, I'm glad I could help.

@Mignari This deserve some attention, it should be merged to master.

Changes in logic to find a compatible client. Previously there was only one OTB version to each Tibia version, with the new 7.x support there is more than one Tibia version to the same OTB version (710->730; 740->750 and 790 -> 792).
With theese changes, now the logics consider a list instead of a single client, it reads the list and try to match it by the dat and spr signature
Fixing typo in version 780
@pasturryx
Copy link

what happened with this ?

@danilopucci
Copy link
Author

what happened with this ?

Hello Felipe,

For now, you can use the compiled version on my branch.

Please, let me know if you find any bug.

@rbgadotti
Copy link

I can't download it,
the link on readme is broken.
Could you help me with that? Really need edit 7.72 items

@danilopucci
Copy link
Author

danilopucci commented May 24, 2023

Try from releases

EDIT: I fixed the download link from my readme. Thanks

@mano368
Copy link

mano368 commented Jun 19, 2023

Try from releases

EDIT: I fixed the download link from my readme. Thanks

hey danilopucci, do you know how to solve this problem on windows 11?

Sem título

@danilopucci
Copy link
Author

Hey, I never tried to run it on win11.

Did you tried to compile it? I think if you try to recompile it, the missing libraries or other kind of error will throw and we can investigate it. Or maybe just by recompiling it will fix the problem.

(I do not have win11 installed)

@MightyGoob
Copy link

@danilopucci I'm looking to use your work on a 7.6 server (Goobers).
Do you happen to have a recent copy of the plug files I need to use?

@MightyGoob
Copy link

@danilopucci I found your recompiled download. It works!
AMAZING!

I was actually hoping for an item editor to have an xml or sql export. Mainly so I can store all my items.otb information in tables to be shown on the website.

Any thoughts on this?

@danilopucci
Copy link
Author

Hey @MightyGoob,

I am not sure if I get it correctly, but maybe you would need something on your gameserver to update the database table with your items.otb. This way you will be 100% sure that your lastest version of items.otb will be reflected on your database table, with no dependencies on any other kind of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants