-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deviceId as an message input parameter #115
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 93
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use additional variables, use the same deviceId
(you can modify declaration to let
instead of const
or and you can do all of this inline at line 48).
Done. Is it ok now? |
Hi,
first of all, thanks for your great job.
I'd like to specify the deviceId inside the message sent to the node and not always inside the node itself, like msg.deviceId= .....
It should is a simple fix, in ewelink-connect.js, just replaced the row:
with following rows:
In this way it the deviceId is not specified inside the node configuration, it will use the one specified inside the message.
Thanks
Claudio