Better handling for empty referer

otwcode · Jul 25, 2024 · 6131f43 · 6131f43
1 parent 660f203
commit 6131f43
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/models/feedback_reporters/support_reporter.rb b/app/models/feedback_reporters/support_reporter.rb
@@ -16,7 +16,7 @@ def custom_zoho_fields
     # The Zoho field supports at most 255 characters. That _should_ be enough, but technically
     # we support ludicrously long URLs because searches can do that. In those cases, just get the
     # first 255 characters.
-    sanitized_url = referer ? referer[0..254] : "Unknown URL"
+    sanitized_url = referer.present? ? referer[0..254] : "Unknown URL"
     {
       "cf_archive_version" => site_revision.presence || "Unknown site revision",
       "cf_rollout" => rollout.presence || "Unknown",

diff --git a/spec/models/feedback_reporters/support_reporter_spec.rb b/spec/models/feedback_reporters/support_reporter_spec.rb
@@ -120,7 +120,7 @@
       end
 
       it "returns a hash containing a blank string for referer" do
-        expect(subject.report_attributes.dig("cf", "cf_url")).to eq("")
+        expect(subject.report_attributes.dig("cf", "cf_url")).to eq("Unknown URL")
       end
     end