AO3-6783 Minor review fixes

otwcode · Aug 4, 2024 · f80eb52 · f80eb52
1 parent 82f63ca
commit f80eb52
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/autocomplete_controller.rb b/app/controllers/autocomplete_controller.rb
@@ -92,9 +92,9 @@ def noncanonical_tag
     raise "Redshirt: Attempted to constantize invalid class initialize noncanonical_tag #{params[:type].classify}" unless Tag::TYPES.include?(params[:type].classify)
 
     tag_class = params[:type].classify.constantize
-    one_tag = tag_class.find_by(canonical: false, name: params[:term])
+    one_tag = tag_class.find_by(canonical: false, name: params[:term]) if params[:term].present?
     # If there is an exact match in the database, ensure it is the first thing suggested.
-    match = if one_tag && params[:term].present?
+    match = if one_tag
               [one_tag.name]
             else
               []

diff --git a/features/tag_sets/tag_set_nominations.feature b/features/tag_sets/tag_set_nominations.feature
@@ -300,7 +300,7 @@ Feature: Nominating and reviewing nominations for a tag set
       But I should not see "Gold"
       And I should see "None nominated in this fandom."
 
-  Scenario: A tag nomination with for the zero width space tag doesn't prevent removing other tag nominations
+  Scenario: A tag nomination with the zero width space tag doesn't prevent removing other tag nominations
     Given a canonical fandom "First"
       And a canonical fandom "Treasure Chest"
       And a zero width space tag exists