AO3-6714 Prevent tag sets becoming ownerless #4863
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6714
Purpose
This PR implements point 2. of the "What should happen" section of AO3-6714. For that specific case, if you:
You are now only removed as a tagset owner once. You remain a tagset owner at least once. This means the tagset cannot be orphaned.
In more general terms, this PR enforces that when removing owners from a tagset:
TagSetOwnership
records removed is at most oneTagSetOwnership
records exist for anOwnedTagSet
Testing Instructions
Follow the reproduction instructions in AO3-6714. You will still be able to create a tagset where a single user owns it twice, but you can no longer remove all owners from the tagset.
References
N/A
Credit
Tom Milligan (they/them)