AO3-6763 Set github action check to fail if reviewdog finds an error #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Tests Only
sarken
added
the
Priority: High - Broken on Test
|
The GitHub repository setting "Allow specified actions and reusable workflows" needs to updated for |
Bilka2
changed the title
brianjaustin
approved these changes
Jul 20, 2024
Done! |
|
I confirmed that the check now shows a failure on #4875 as it should 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6763, broken on test II
Purpose
Sets fail_on_error for the reviewdog action so that the check is shown as failed when rubocop or erb-lint find an error. Currently the check shows as passed, see e.g. #4875.
Testing Instructions
Merge this into a PR with rubocop or erb-lint warnings and make sure that the reviewdog check on the PR fails.
References
Example PR: brianjaustin#1
Credit
Bilka (he/him)