Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6759 Check admin roles for actions in TagWranglersController #4885

Merged

Conversation

brianjaustin
Copy link
Member

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6759

Purpose

Update the TagWranglersController to verify the current admin has the right roles to access each action

Credit

Brian Austin (they/he)

Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just a few notes regarding the tests.

spec/controllers/tag_wranglers_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/tag_wranglers_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/tag_wranglers_controller_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@brianjaustin brianjaustin merged commit f7c1111 into otwcode:master Aug 14, 2024
29 checks passed
@brianjaustin brianjaustin deleted the AO3-6759-tag-wranglers-admin branch August 14, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants