-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6010 Add role for Legal #4889
AO3-6010 Add role for Legal #4889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions regarding mismatches between Jira and what was implemented and a few notes for the tests.
admin_users_controller_spec.rb
is missing a few tests:
- test that update doesn't allow legal to change email or roles
- test that update_next_of_kin, update_status, confirm_delete_user_creations, destroy_user_creations doesn't allow the unauthorized admin roles to do changes/access the actions
- activate and troubleshoot aren't testing any roles besides support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Wait, sorry, I missed my own comment regarding tests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Pull Request Checklist
Issue
https://otwarchive.atlassian.net/browse/AO3-6010
Purpose
Add a role for our Legal folks, along with some permissions for that role
Credit
Brian Austin (they/he)