-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6698 Limit roles that can modify archive FAQs #4894
Open
Bilka2
wants to merge
11
commits into
otwcode:master
Choose a base branch
from
Bilka2:AO3-6698-admin-roles-faq
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small note for the tests, otherwise LGTM
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Sep 12, 2024
brianjaustin
approved these changes
Sep 13, 2024
brianjaustin
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
Sep 13, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6698
Purpose
Limits editing of English archive FAQs to superadmin, docs and support admins. Limits editing of translated FAQs to superadmin, docs, support and translation admins.
Disables creation, reordering and deletion of translated FAQs at the controller level (previously only disabled in the view).
Testing Instructions
See Jira.
References
Exempt from open PR limit due to current project priorities.
Credit
Bilka (he/him)