Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6698 Limit roles that can modify archive FAQs #4894

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Aug 8, 2024

Issue

https://otwarchive.atlassian.net/browse/AO3-6698

Purpose

Limits editing of English archive FAQs to superadmin, docs and support admins. Limits editing of translated FAQs to superadmin, docs, support and translation admins.

Disables creation, reordering and deletion of translated FAQs at the controller level (previously only disabled in the view).

Testing Instructions

See Jira.

References

Exempt from open PR limit due to current project priorities.

Credit

Bilka (he/him)

@brianjaustin brianjaustin self-requested a review September 1, 2024 23:40
Copy link
Member

@brianjaustin brianjaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note for the tests, otherwise LGTM

features/step_definitions/admin_steps.rb Show resolved Hide resolved
config/locales/controllers/en.yml Outdated Show resolved Hide resolved
features/admins/admin_post_faqs.feature Outdated Show resolved Hide resolved
features/admins/admin_post_faqs.feature Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants