Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO3-6268 Fix All challenge owners/moderators get CCed in "Assignments sent" notification #4912

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

AO3-6268 Fix All challenge owners/moderators get CCed in "Assignments sent" notification #4912

wants to merge 20 commits into from

Commits on Sep 16, 2024

  1. let each challenge owner receive their own email rather than all chal… 

    …lenge owners get cc-ed on the same email
    @Cesium-Ice
    Cesium-Ice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    25e6ed1 View commit details
    Browse the repository at this point in the history

  2. address rubocop

    @Cesium-Ice
    Cesium-Ice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    fdfca33 View commit details
    Browse the repository at this point in the history

  3. remove redundant return

    @Cesium-Ice
    Cesium-Ice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c8d8fe2 View commit details
    Browse the repository at this point in the history

  4. another reviewdog fix

    @Cesium-Ice
    Cesium-Ice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7fb0d0b View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. rubocop autocorrections

    @Cesium-Ice
    Cesium-Ice committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7b51ffd View commit details
    Browse the repository at this point in the history

  2. address Bilka comments

    @Cesium-Ice
    Cesium-Ice committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d4da2da View commit details
    Browse the repository at this point in the history

  3. rubocop linter changes

    @Cesium-Ice
    Cesium-Ice committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1f0242e View commit details
    Browse the repository at this point in the history

  4. fix unused translation

    @Cesium-Ice
    Cesium-Ice committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f9e91ce View commit details
    Browse the repository at this point in the history

  5. yet more rubocop autocorrection changes

    @Cesium-Ice
    Cesium-Ice committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5e92d68 View commit details
    Browse the repository at this point in the history

  6. fix broken UTs by fixing defining t in notify_maintainers_challenge_s… 

    …ent function
    @Cesium-Ice
    Cesium-Ice committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a4f6c63 View commit details
    Browse the repository at this point in the history

  7. rubocop change keyword argument from default = true to default: true

    @Cesium-Ice
    Cesium-Ice committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    85681cb View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. address bilka comments

    @Cesium-Ice
    Cesium-Ice committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    13bd956 View commit details
    Browse the repository at this point in the history

  2. address rubocop and fix broken cucumber test

    @Cesium-Ice
    Cesium-Ice committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    cde3a74 View commit details
    Browse the repository at this point in the history

  3. will rubocop finally be satisfied?

    @Cesium-Ice
    Cesium-Ice committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    047a875 View commit details
    Browse the repository at this point in the history

  4. see if rubocop will let me get away with not fixing all instances of … 

    …ts()
    @Cesium-Ice
    Cesium-Ice committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    450dbeb View commit details
    Browse the repository at this point in the history

  5. rubocop change not about ts

    @Cesium-Ice
    Cesium-Ice committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    c28acc5 View commit details
    Browse the repository at this point in the history

  6. internationalize collection.rb

    @Cesium-Ice
    Cesium-Ice committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    ec338b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Revert "internationalize collection.rb" 

    This reverts commit ec338b0.
    @Cesium-Ice
    Cesium-Ice committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e05c37b View commit details
    Browse the repository at this point in the history

  2. Revert "see if rubocop will let me get away with not fixing all insta… 

    …nces of ts()"

This reverts commit 450dbeb.
    @Cesium-Ice
    Cesium-Ice committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ff9a9c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. internationalize default email, minor refactoring, add more UTs

    @Cesium-Ice
    Cesium-Ice committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e86c8a0 View commit details
    Browse the repository at this point in the history