AO3-6768 update browser page title in drafts page #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Thank you for the PR @mystyrust! Someone should be along to review it soon. In the meantime, I have assigned the Jira ticket to your user and marked it as "In Review" so no one else picks it up by accident. I've also given your Jira user some basic permissions, including the ability to assign yourself to tickets in the future. |
Bilka2
suggested changes
Sep 17, 2024
There was a problem hiding this comment.
Thank you for contributing!
The code works, but it would be nice to get it internationalized (i18n). Furthermore, it would be nice to have a test for this change - the I should see the page title "..." cucumber step should fit into one of the scenarios in /features/works/work_drafts.feature.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Bilka2
reviewed
Sep 18, 2024
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Bilka2
suggested changes
Sep 18, 2024
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6768
Purpose
fixes the browser title to be consistent with other pages in the users profile
Testing Instructions
follow instructions as listed in jira ticket
References
similar to #4916 (may have merge conflict with this pr since both edit the same en.yml file)
Credit
mystyrust, she/her