-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
Thanks for your submission, looks interesting.
Let me take a closer look and see if it could fit into our process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I tried it out tonight, and it's really cool. ✨ Thanks for creating this and I think it could definitely be useful in our process. I'd like to request a few changes before merging.
-
For consistency, we want to always use English as the source language. (It's also the fallback language for the i18n in the main project) Could you please change the command to only accept a TARGET_LANGUAGE and always translate from English?
-
It might be useful to have a mode that focuses on missing keys in the TARGET_LANGUAGE, as we have over 136 keys now.
Thanks again!
tools/README.md
Outdated
@@ -0,0 +1,23 @@ | |||
# Translation Manager | |||
|
|||
For a faster translation process, consider using the interactive translation manager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that many people who visit our repo are using GitHub for the first time, so this will only be faster for a percentage of users. It might be worth noting that this tool requires familiarity with the command line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished all the points you mentioned 🎉
- Default mode is now that only missing keys will be translated 🔑
- The readme is updated to address the familiarity issue 👨👩👦
- The "force recreate all keys" option is now accessible by passing the flag
-recreate
to the command 🎯
The
recreate
flag is useful if you want to proof-check keys since it shows you the English source sentence alongside the current translation. Translations that you consider good can be simply inherited when you leave the prompt empty.
This should be much faster than having 2 files open and comparing it with the English source.
I also used it for the other PR earlier to proof-check and fix the issues in the German localization 🤗
Last but not least, if this marks the PR as merge-ready, please add the hacktoberfest-accepted
label to this PR! 🤗
(I noticed that the Hacktoberfest-label is on the main-repo of Find a Doc, but not on this repo... 🥲)
Hacktoberfest
See you on Slack for the next projects! 😇
🚸 import readline to support arrow keys on input()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really slick. I like that I can hit enter to keep the current translation, or write a change.
Very good work.
Issues
Addresses issue #149
Changelog: 📝
InvalidLanguageError
exception in case an invalid language has been requested for translation.KeyboardInterrupt
exception handling.Check the following video for what the interactive translation manager does:
![animation](https://user-images.githubusercontent.com/59295964/136704972-6e97ed33-fbc9-4ff1-ab0a-74d1f5808041.gif)
TODO: ☑️
Other
Please add the
hacktoberfest-accepted
label to this pull request if it is accepted! 😃