Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement button on GitHub to update locale files #1004

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

NabbeunNabi
Copy link
Contributor

@NabbeunNabi NabbeunNabi commented Feb 6, 2025

Resolves #690

🔧 What changed

Before on push it would lint the locales and auto update them for you. Now you can run the script yourself locally. Or press a button on GitHub to run a webhook that runs the script for you that will commit and push for you. This makes it so if developers don't run yarn prepare that they can still have a button on GitHub when they create a PR. Also it keeps from autorunning and updating files when a feature is not done being worked on through every commit push if translations are added.

📸 Screenshots

  • After

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for findadoc ready!

Name Link
🔨 Latest commit 5d09c4e
🔍 Latest deploy log https://app.netlify.com/sites/findadoc/deploys/67a66f2f6aa34400081da5b5
😎 Deploy Preview https://deploy-preview-1004--findadoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NabbeunNabi NabbeunNabi changed the title Feat/implement locales auto fix feat: implement button on GitHub to update locale files Feb 6, 2025
@NabbeunNabi NabbeunNabi force-pushed the feat/implement-locales-auto-fix branch from 9a73ba0 to 08f3e9e Compare February 6, 2025 02:40
@ourjapanlife ourjapanlife deleted a comment from github-actions bot Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Missing Locale Keys Found: - cn.json:

  • hiPhil.teehee
  • de.json:
  • hiPhil.teehee
  • fr.json:
  • hiPhil.teehee
  • it.json:
  • hiPhil.teehee
  • ja.json:
  • hiPhil.teehee
  • pt.json:
  • hiPhil.teehee
  • ru.json:
  • hiPhil.teehee
  • tl.json:
  • hiPhil.teehee
  • vi.json:
  • hiPhil.teehee

Fix Missing Keys

To fix the missing keys, click the button above or run the following command in your terminal:

yarn lint:locales

@NabbeunNabi NabbeunNabi closed this Feb 6, 2025
@NabbeunNabi NabbeunNabi reopened this Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Missing Locale Keys Found: - cn.json:

  • hiPhil.teehee
  • de.json:
  • hiPhil.teehee
  • fr.json:
  • hiPhil.teehee
  • it.json:
  • hiPhil.teehee
  • ja.json:
  • hiPhil.teehee
  • pt.json:
  • hiPhil.teehee
  • ru.json:
  • hiPhil.teehee
  • tl.json:
  • hiPhil.teehee
  • vi.json:
  • hiPhil.teehee

Fix Missing Keys

To fix the missing keys, click the button above or run the following command in your terminal:

yarn lint:locales

2 similar comments
Copy link

github-actions bot commented Feb 6, 2025

Missing Locale Keys Found: - cn.json:

  • hiPhil.teehee
  • de.json:
  • hiPhil.teehee
  • fr.json:
  • hiPhil.teehee
  • it.json:
  • hiPhil.teehee
  • ja.json:
  • hiPhil.teehee
  • pt.json:
  • hiPhil.teehee
  • ru.json:
  • hiPhil.teehee
  • tl.json:
  • hiPhil.teehee
  • vi.json:
  • hiPhil.teehee

Fix Missing Keys

To fix the missing keys, click the button above or run the following command in your terminal:

yarn lint:locales

Copy link

github-actions bot commented Feb 6, 2025

Missing Locale Keys Found: - cn.json:

  • hiPhil.teehee
  • de.json:
  • hiPhil.teehee
  • fr.json:
  • hiPhil.teehee
  • it.json:
  • hiPhil.teehee
  • ja.json:
  • hiPhil.teehee
  • pt.json:
  • hiPhil.teehee
  • ru.json:
  • hiPhil.teehee
  • tl.json:
  • hiPhil.teehee
  • vi.json:
  • hiPhil.teehee

Fix Missing Keys

To fix the missing keys, click the button above or run the following command in your terminal:

yarn lint:locales

@theyokohamalife
Copy link
Contributor

This seems like it'll be a really nice new feature! Looking forward to it!

@NabbeunNabi NabbeunNabi force-pushed the feat/implement-locales-auto-fix branch from 0103e00 to 79186fb Compare February 7, 2025 07:37
Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found: - cn.json:

  • hiPhil.teehee
  • de.json:
  • hiPhil.teehee
  • fr.json:
  • hiPhil.teehee
  • it.json:
  • hiPhil.teehee
  • ja.json:
  • hiPhil.teehee
  • pt.json:
  • hiPhil.teehee
  • ru.json:
  • hiPhil.teehee
  • tl.json:
  • hiPhil.teehee
  • vi.json:
  • hiPhil.teehee

Fix Missing Keys

To fix the missing keys, click the button above or run the following command in your terminal:

yarn lint:locales

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

  • cn.json:
  • hiPhil.teehee
  • de.json:
  • hiPhil.teehee
  • fr.json:
  • hiPhil.teehee
  • it.json:
  • hiPhil.teehee
  • ja.json:
  • hiPhil.teehee
  • pt.json:
  • hiPhil.teehee
  • ru.json:
  • hiPhil.teehee
  • tl.json:
  • hiPhil.teehee
  • vi.json:
  • hiPhil.teehee

To fix the missing keys, react with a 🚀 emoji

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

  • cn.json:

  • hiPhil.teehee

  • de.json:

  • hiPhil.teehee

  • fr.json:

  • hiPhil.teehee

  • it.json:

  • hiPhil.teehee

  • ja.json:

  • hiPhil.teehee

  • pt.json:

  • hiPhil.teehee

  • ru.json:

  • hiPhil.teehee

  • tl.json:

  • hiPhil.teehee

  • vi.json:

  • hiPhil.teehee

To fix the missing keys, react with a 🚀 emoji

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

  • cn.json:

  • hiPhil.teehee

  • de.json:

  • hiPhil.teehee

  • fr.json:

  • hiPhil.teehee

  • it.json:

  • hiPhil.teehee

  • ja.json:

  • hiPhil.teehee

  • pt.json:

  • hiPhil.teehee

  • ru.json:

  • hiPhil.teehee

  • tl.json:

  • hiPhil.teehee

  • vi.json:

  • hiPhil.teehee

To fix the missing keys, react with a 🚀 emoji

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

  • cn.json:

  • hiPhil.teehee

  • de.json:

  • hiPhil.teehee

  • fr.json:

  • hiPhil.teehee

  • it.json:

  • hiPhil.teehee

  • ja.json:

  • hiPhil.teehee

  • pt.json:

  • hiPhil.teehee

  • ru.json:

  • hiPhil.teehee

  • tl.json:

  • hiPhil.teehee

  • vi.json:

  • hiPhil.teehee

To fix the missing keys, react with a 🚀 emoji

* fix: change workflow conditions

* feat: update comment styling
Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

cn.json:

  • hiPhil.teehee

de.json:

  • hiPhil.teehee

fr.json:

  • hiPhil.teehee

it.json:

  • hiPhil.teehee

ja.json:

  • hiPhil.teehee

pt.json:

  • hiPhil.teehee

ru.json:

  • hiPhil.teehee

tl.json:

  • hiPhil.teehee

vi.json:

  • hiPhil.teehee

To fix the missing keys, react with a 🚀 emoji

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

cn.json:

  • hiPhil.teehee

de.json:

  • hiPhil.teehee

fr.json:

  • hiPhil.teehee

it.json:

  • hiPhil.teehee

ja.json:

  • hiPhil.teehee

pt.json:

  • hiPhil.teehee

ru.json:

  • hiPhil.teehee

tl.json:

  • hiPhil.teehee

vi.json:

  • hiPhil.teehee

To add the missing keys, comment with the following command:

Fix missing locale keys 🌍

@NabbeunNabi
Copy link
Contributor Author

Fix missing locale keys 🌍

1 similar comment
@NabbeunNabi
Copy link
Contributor Author

Fix missing locale keys 🌍

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

cn.json:

  • hiPhil.teehee

de.json:

  • hiPhil.teehee

fr.json:

  • hiPhil.teehee

it.json:

  • hiPhil.teehee

ja.json:

  • hiPhil.teehee

pt.json:

  • hiPhil.teehee

ru.json:

  • hiPhil.teehee

tl.json:

  • hiPhil.teehee

vi.json:

  • hiPhil.teehee

To add the missing keys, comment with the following command:

fix missing locale keys

@NabbeunNabi
Copy link
Contributor Author

fix missing locale keys

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

cn.json:

  • hiPhil.teehee

de.json:

  • hiPhil.teehee

fr.json:

  • hiPhil.teehee

it.json:

  • hiPhil.teehee

ja.json:

  • hiPhil.teehee

pt.json:

  • hiPhil.teehee

ru.json:

  • hiPhil.teehee

tl.json:

  • hiPhil.teehee

vi.json:

  • hiPhil.teehee

To add the missing keys, comment with the following command:

fix missing locale keys

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

cn.json:

  • hiPhil.teehee

de.json:

  • hiPhil.teehee

fr.json:

  • hiPhil.teehee

it.json:

  • hiPhil.teehee

ja.json:

  • hiPhil.teehee

pt.json:

  • hiPhil.teehee

ru.json:

  • hiPhil.teehee

tl.json:

  • hiPhil.teehee

vi.json:

  • hiPhil.teehee

To add the missing keys, comment with the following line:

/add-missing-locales

@NabbeunNabi
Copy link
Contributor Author

/add-missing-locales

Copy link

github-actions bot commented Feb 7, 2025

Missing Locale Keys Found:

cn.json:

  • hiPhil.teehee

de.json:

  • hiPhil.teehee

fr.json:

  • hiPhil.teehee

it.json:

  • hiPhil.teehee

ja.json:

  • hiPhil.teehee

pt.json:

  • hiPhil.teehee

ru.json:

  • hiPhil.teehee

tl.json:

  • hiPhil.teehee

vi.json:

  • hiPhil.teehee

To add the missing keys, comment with the following line:

/add-missing-locales

@NabbeunNabi
Copy link
Contributor Author

/add-missing-locales

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research: i18n locales file PR messaging and branch updating
2 participants