-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement button on GitHub to update locale files #1004
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for findadoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9a73ba0
to
08f3e9e
Compare
Missing Locale Keys Found: - cn.json:
To fix the missing keys, click the button above or run the following command in your terminal: yarn lint:locales |
Missing Locale Keys Found: - cn.json:
To fix the missing keys, click the button above or run the following command in your terminal: yarn lint:locales |
2 similar comments
Missing Locale Keys Found: - cn.json:
To fix the missing keys, click the button above or run the following command in your terminal: yarn lint:locales |
Missing Locale Keys Found: - cn.json:
To fix the missing keys, click the button above or run the following command in your terminal: yarn lint:locales |
This seems like it'll be a really nice new feature! Looking forward to it! |
0103e00
to
79186fb
Compare
Missing Locale Keys Found: - cn.json:
To fix the missing keys, click the button above or run the following command in your terminal: yarn lint:locales |
Missing Locale Keys Found:
To fix the missing keys, react with a 🚀 emoji |
Missing Locale Keys Found:
To fix the missing keys, react with a 🚀 emoji |
Missing Locale Keys Found:
To fix the missing keys, react with a 🚀 emoji |
Missing Locale Keys Found:
To fix the missing keys, react with a 🚀 emoji |
Missing Locale Keys Found:cn.json:
de.json:
fr.json:
it.json:
ja.json:
pt.json:
ru.json:
tl.json:
vi.json:
To fix the missing keys, react with a 🚀 emoji |
Missing Locale Keys Found:cn.json:
de.json:
fr.json:
it.json:
ja.json:
pt.json:
ru.json:
tl.json:
vi.json:
To add the missing keys, comment with the following command:
|
Fix missing locale keys 🌍 |
1 similar comment
Fix missing locale keys 🌍 |
Missing Locale Keys Found:cn.json:
de.json:
fr.json:
it.json:
ja.json:
pt.json:
ru.json:
tl.json:
vi.json:
To add the missing keys, comment with the following command:
|
fix missing locale keys |
…ourjapanlife/findadoc-web into feat/implement-locales-auto-fix
Missing Locale Keys Found:cn.json:
de.json:
fr.json:
it.json:
ja.json:
pt.json:
ru.json:
tl.json:
vi.json:
To add the missing keys, comment with the following command:
|
Missing Locale Keys Found:cn.json:
de.json:
fr.json:
it.json:
ja.json:
pt.json:
ru.json:
tl.json:
vi.json:
To add the missing keys, comment with the following line:
|
/add-missing-locales |
Missing Locale Keys Found:cn.json:
de.json:
fr.json:
it.json:
ja.json:
pt.json:
ru.json:
tl.json:
vi.json:
To add the missing keys, comment with the following line:
|
/add-missing-locales |
Resolves #690
🔧 What changed
Before on push it would lint the locales and auto update them for you. Now you can run the script yourself locally. Or press a button on GitHub to run a webhook that runs the script for you that will commit and push for you. This makes it so if developers don't run
yarn prepare
that they can still have a button on GitHub when they create a PR. Also it keeps from autorunning and updating files when a feature is not done being worked on through every commit push if translations are added.📸 Screenshots
After