changed from apolloclient to graphql-request #325

ermish · 2023-12-11T14:03:41Z

Resolves #369
Resolves #348
Resolves #366

What changed

changed from apolloclient to graphql-request (see Change from apollojs client to graphql-request #369 for more details)
Fixed the state stores to use the new fetching format
Tested new data fetching design

Testing instructions

Tests aren't currently running (need to fix ASAP), so manually verify the page looks good and data is fetching properly

netlify · 2023-12-11T14:03:47Z

✅ Deploy Preview for findadoc ready!

Name	Link
🔨 Latest commit	`bacd52e`
🔍 Latest deploy log	https://app.netlify.com/sites/findadoc/deploys/65f84abc8040070008a232d4
😎 Deploy Preview	https://deploy-preview-325--findadoc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

socket-security · 2023-12-11T14:05:16Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@antfu/[email protected]	None	`0`	105 kB	antfu
npm/@nuxt/[email protected]	None	`0`	21.7 kB	danielroe
npm/@nuxt/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+218`	92.1 MB	antfu
npm/@nuxt/[email protected]	Transitive: environment, filesystem, shell	`+32`	6.52 MB	antfu
npm/@nuxt/[email protected]	environment, network Transitive: eval, filesystem, shell, unsafe	`+218`	92.1 MB	antfu
npm/@nuxt/[email protected]	environment, filesystem, network Transitive: shell, unsafe	`+141`	21.3 MB	danielroe
npm/@nuxt/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+173`	69.8 MB	danielroe
npm/@unhead/[email protected]	None	`0`	16.1 kB	harlan_zw
npm/@unhead/[email protected]	None	`0`	9.91 kB	harlan_zw
npm/@unhead/[email protected]	environment Transitive: eval, filesystem, unsafe	`+15`	41.4 MB	harlan_zw
npm/@vitejs/[email protected]	environment Transitive: eval, filesystem, network, shell, unsafe	`+23`	52.1 MB	vitebot
npm/[email protected]	None	`0`	4.83 kB	lukekarrys
npm/[email protected]	None	`0`	3.4 kB	kevva
npm/[email protected]	None	`0`	26.3 kB	antfu
npm/[email protected]	None	`0`	1.33 kB	feedic
npm/[email protected]	None	`0`	16.9 kB	pi0
npm/[email protected]	None	`0`	11.1 kB	pi0
npm/[email protected]	None	`0`	25.6 kB	rich_harris
npm/[email protected]	None	`0`	15.2 kB	antfu
npm/[email protected]	environment, filesystem, network, shell	`0`	135 kB	evanw
npm/[email protected]	None	`0`	22.8 kB	dap
npm/[email protected]	environment	`0`	24.6 kB	pi0
npm/[email protected]	Transitive: environment, network	`+12`	2 MB	pi0
npm/[email protected]	None	`0`	42.7 kB	pi0
npm/[email protected]	None	`0`	3.54 kB	sindresorhus
npm/[email protected]	None	`0`	26.1 kB	kriszyp
npm/[email protected]	None	`0`	19.4 kB	ljharb
npm/[email protected]	None	`0`	23.2 kB	lukeed
npm/[email protected]	environment, filesystem, shell	`+2`	64.8 kB	soda
npm/[email protected]	None	`0`	206 kB	dougwilson
npm/[email protected]	environment, filesystem, network Transitive: shell, unsafe	`+101`	11.2 MB	pi0
npm/[email protected]	None	`+1`	5.36 MB	pi0
npm/[email protected]	environment, network	`+3`	915 kB	pi0
npm/[email protected]	environment, filesystem, network	`+3`	540 kB	npm-cli-ops
npm/[email protected]	None	`0`	30.7 kB	pi0
npm/[email protected]	None	`0`	11.7 kB	coolaj86
npm/[email protected]	None	`0`	7.43 kB	ionicabizau
npm/[email protected]	Transitive: environment	`+2`	983 kB	simple-git, steveukx
npm/[email protected]	filesystem	`0`	20.7 kB	lukeed
npm/[email protected]	None	`+1`	57.9 kB	gkz
npm/[email protected]	None	`0`	357 kB	natemoo-re
npm/[email protected]	None	`0`	7.87 kB	pi0
npm/[email protected]	Transitive: environment, network	`+5`	1.48 MB	pi0
npm/[email protected]	filesystem Transitive: environment, eval, unsafe	`+56`	50.3 MB	posva
npm/[email protected]	Transitive: environment, filesystem, network	`+28`	2.84 MB	pi0
npm/[email protected]	Transitive: environment	`+2`	70.1 kB	dap
npm/[email protected]	environment, filesystem Transitive: eval, network, shell, unsafe	`+24`	15.7 MB	sxzz
npm/[email protected]	environment, filesystem Transitive: eval, network, shell, unsafe	`+67`	24 MB	webfansplz
npm/[email protected]	None	`+1`	144 kB	danielroe
npm/[email protected]	None	`0`	4.86 kB	pi0

View full report↗︎

Anissa3005

As a Junior I approve 👌

theyokohamalife

Netlify fails to build with these changes. It looks like we're making a bad request to the API:

socket-security · 2024-03-11T11:25:34Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note
Telemetry	npm/@nuxt/[email protected]	Note: Can be disabled by setting the environment variable NUXT_TELEMETRY_DISABLED=1
Install scripts	npm/[email protected]	Install script: postinstall Source: `node install.js`

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/@nuxt/[email protected]
@SocketSecurity ignore npm/[email protected]

NabbeunNabi · 2024-03-11T15:46:29Z

The checks pass now. It is not resolving the duplicate locations still from what I see but I fixed the build problem I believe. I can remove those semicolons as well if they aren't supposed to be there. The problem was the yarn.lock needed to be rebuilt since since it was throwing errors for toUpperCase, and then the endpoint wasn't correct in the utils/graphql.ts

NabbeunNabi · 2024-03-12T10:22:21Z

Just as a question. Does it resolve the bottom two issues as well or just the original one?

NabbeunNabi · 2024-03-13T14:23:48Z

I do not think this currently resolves the duplicate search results. I do not know what the best solution would be but I think if there is a script that creates a lookup like { city: count} as the key value pair we could dynamically render it using v-for then later. But I do not know if we need this extra function in the script or if there is a better solution. Should it be solved on the frontend/backend/in the store?

ermish · 2024-03-14T22:54:00Z

I do not think this currently resolves the duplicate search results. I do not know what the best solution would be but I think if there is a script that creates a lookup like { city: count} as the key value pair we could dynamically render it using v-for then later. But I do not know if we need this extra function in the script or if there is a better solution. Should it be solved on the frontend/backend/in the store?

@NabbeunNabi that's a good question! we could solve in either the front end or backend. For now, I think front-end will be easier and should be fine for the result quantity. If it gets too heavy, we can shift to the backend.

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix: debug the ESLint config file Previously, the eslint file is not applying the linting and styling rules to our code * chore: format files with new linting rules * fixup! chore: format files with new linting rules --------- Co-authored-by: theyokohamalife <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* test: add tests for localeStore Previously, there were no tests present for the localeStore. In this commit I have created tests for localeStore * fixup! test: add tests for localeStore

This change adds the board members, developers and links to their linkedIn profiles for the ones that are currently available. There are tests for the additions as well. Changed the styling for the map container and main app in order to not have the footer cut through parts of the page.

ermish · 2024-03-18T14:18:50Z

ok everything is merged, working, CI builds, and ready for review again @theyokohamalife !

theyokohamalife

LGTM ✨ Thank you!

ermish added enhancement New feature or request design labels Dec 11, 2023

ermish self-assigned this Dec 11, 2023

ermish marked this pull request as ready for review February 3, 2024 14:38

ermish requested review from theyokohamalife and Anissa3005 February 3, 2024 14:38

Anissa3005 approved these changes Feb 8, 2024

View reviewed changes

theyokohamalife requested changes Feb 18, 2024

View reviewed changes

ermish added 2 commits March 11, 2024 20:23

changed from apolloclient to graphql-request

4aaf272

updated queries with new fetch format

df486cb

NabbeunNabi force-pushed the ermish/graphql-request branch from b1fe24a to df486cb Compare March 11, 2024 11:24

fixup! changed from apolloclient to graphql-request

4d23f35

NabbeunNabi requested a review from theyokohamalife March 11, 2024 14:43

NabbeunNabi self-assigned this Mar 12, 2024

cleaned up added semicolons

6487e6c

allcontributors bot and others added 8 commits March 18, 2024 22:32

docs: add NabbeunNabi as a contributor for code (#410)

26a6af2

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add Anissa3005 as a contributor for code (#411)

39a3417

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

docs: add evan-desu as a contributor for code (#412)

ac6ceeb

* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

chore(deps): update graphqlcodegenerator monorepo (#408)

d6c123a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Add tests for localeStore (#401)

6f52256

* test: add tests for localeStore Previously, there were no tests present for the localeStore. In this commit I have created tests for localeStore * fixup! test: add tests for localeStore

merge fixes. rebuilt yarn

6dc473a

ermish added 3 commits March 18, 2024 22:50

Merge branch 'main' into ermish/graphql-request

6ba12ab

rebuilding yarn lock file

4362292

merge fixes. linting errors

bacd52e

theyokohamalife approved these changes Mar 18, 2024

View reviewed changes

ermish merged commit 11d3b34 into main Mar 18, 2024
8 of 9 checks passed

ermish deleted the ermish/graphql-request branch March 18, 2024 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

changed from apolloclient to graphql-request #325

changed from apolloclient to graphql-request #325

ermish commented Dec 11, 2023 •

edited by NabbeunNabi

Loading

netlify bot commented Dec 11, 2023 •

edited

Loading

socket-security bot commented Dec 11, 2023 •

edited

Loading

Anissa3005 left a comment •

edited

Loading

theyokohamalife left a comment

socket-security bot commented Mar 11, 2024 •

edited

Loading

NabbeunNabi commented Mar 11, 2024

NabbeunNabi commented Mar 12, 2024

NabbeunNabi commented Mar 13, 2024

ermish commented Mar 14, 2024 •

edited

Loading

ermish commented Mar 18, 2024

theyokohamalife left a comment

changed from apolloclient to graphql-request #325

changed from apolloclient to graphql-request #325

Conversation

ermish commented Dec 11, 2023 • edited by NabbeunNabi Loading

What changed

Testing instructions

netlify bot commented Dec 11, 2023 • edited Loading

✅ Deploy Preview for findadoc ready!

socket-security bot commented Dec 11, 2023 • edited Loading

Anissa3005 left a comment • edited Loading

Choose a reason for hiding this comment

theyokohamalife left a comment

Choose a reason for hiding this comment

socket-security bot commented Mar 11, 2024 • edited Loading

Next steps

NabbeunNabi commented Mar 11, 2024

NabbeunNabi commented Mar 12, 2024

NabbeunNabi commented Mar 13, 2024

ermish commented Mar 14, 2024 • edited Loading

ermish commented Mar 18, 2024

theyokohamalife left a comment

Choose a reason for hiding this comment

ermish commented Dec 11, 2023 •

edited by NabbeunNabi

Loading

netlify bot commented Dec 11, 2023 •

edited

Loading

socket-security bot commented Dec 11, 2023 •

edited

Loading

Anissa3005 left a comment •

edited

Loading

socket-security bot commented Mar 11, 2024 •

edited

Loading

ermish commented Mar 14, 2024 •

edited

Loading