-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lang): update language dropdown options for search and i18n #901
Conversation
✅ Deploy Preview for findadoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
287e77c
to
c23cf78
Compare
c23cf78
to
1dc93e0
Compare
This feels like a backwards direction. |
I would love to do that. But currently the standards are that a native speaker needs to translate the languages. If we could use a translation API or Chatgpt to translate our text and the have a native speaker verify it that would be great. In this case @ermish it is something that has no functionality and shows that we have a language translated we do not. I would be happy to search for alternatives. So currently the solutions I can see are:
@theyokohamalife any thoughts? |
I think this is a good question for @theyokohamalife to confirm. After thinking it through again, option #1 maybe is the best and we can provide a way to request a language or contribute to one. Perhaps we can make issues for two future features and go with your PR here |
Approach #1 sounds good to me. |
b5b73e4
to
d9dcfb6
Compare
d9dcfb6
to
14d4a4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shift it!
Resolves #900
🔧 What changed
localeDisplayOptions
since even though we might not have the site translated yet within the language. We might have a doctor who speaks that language. As we do for Tagalog.📸 Screenshots
Before
After