Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): update language dropdown options for search and i18n #901

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

NabbeunNabi
Copy link
Contributor

@NabbeunNabi NabbeunNabi commented Nov 18, 2024

Resolves #900

🔧 What changed

  1. Swahili was removed from the options of what we have translated on our site. Even though we have a doctor that speaks Swahili. There is no translation of Swahili.
  2. The search bar languages were changed to all the ones we include as localeDisplayOptions since even though we might not have the site translated yet within the language. We might have a doctor who speaks that language. As we do for Tagalog.

📸 Screenshots

  • Before

image
image

  • After

image
image

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for findadoc ready!

Name Link
🔨 Latest commit dee7591
🔍 Latest deploy log https://app.netlify.com/sites/findadoc/deploys/6750351991b6fe0008edcab1
😎 Deploy Preview https://deploy-preview-901--findadoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NabbeunNabi NabbeunNabi force-pushed the fix/remove-untranslated-swahili branch from 287e77c to c23cf78 Compare November 18, 2024 01:50
@NabbeunNabi NabbeunNabi self-assigned this Nov 18, 2024
@NabbeunNabi NabbeunNabi force-pushed the fix/remove-untranslated-swahili branch from c23cf78 to 1dc93e0 Compare November 18, 2024 01:55
@NabbeunNabi NabbeunNabi marked this pull request as ready for review November 18, 2024 02:10
@ermish
Copy link
Contributor

ermish commented Nov 18, 2024

This feels like a backwards direction.
Can we add Swahili translations instead of removing the language?

@NabbeunNabi
Copy link
Contributor Author

NabbeunNabi commented Nov 18, 2024

This feels like a backwards direction. Can we add Swahili translations instead of removing the language?

I would love to do that. But currently the standards are that a native speaker needs to translate the languages. If we could use a translation API or Chatgpt to translate our text and the have a native speaker verify it that would be great. In this case @ermish it is something that has no functionality and shows that we have a language translated we do not. I would be happy to search for alternatives.

So currently the solutions I can see are:

  1. Remove the facade that we have it translated in Swahili but show all the options to select doctors (As I said we have two doctors who speak Tagalog and didn't have a search possibility and that could be the same going forward for other languages)
  2. Change our standards on who translates our sites to an API of some sort and let those contact us if they find flaws as a native speaker
  3. Contact someone who is a native Swahili speaker. But I do not know any as of this moment.

@theyokohamalife any thoughts?

@ermish
Copy link
Contributor

ermish commented Nov 18, 2024

This feels like a backwards direction. Can we add Swahili translations instead of removing the language?

I would love to do that. But currently the standards are that a native speaker needs to translate the languages. If we could use a translation API or Chatgpt to translate our text and the have a native speaker verify it that would be great. In this case @ermish it is something that has no functionality and shows that we have a language translated we do not. I would be happy to search for alternatives.

So currently the solutions I can see are:

  1. Remove the facade that we have it translated in Swahili but show all the options to select doctors (As I said we have two doctors who speak Tagalog and didn't have a search possibility and that could be the same going forward for other languages)
  2. Change our standards on who translates our sites to an API of some sort and let those contact us if they find flaws as a native speaker
  3. Contact someone who is a native Swahili speaker. But I do not know any as of this moment.

@theyokohamalife any thoughts?

I think this is a good question for @theyokohamalife to confirm. After thinking it through again, option #1 maybe is the best and we can provide a way to request a language or contribute to one. Perhaps we can make issues for two future features and go with your PR here

components/SearchBar.vue Outdated Show resolved Hide resolved
components/SearchBar.vue Outdated Show resolved Hide resolved
@theyokohamalife
Copy link
Contributor

Approach #1 sounds good to me.

@NabbeunNabi NabbeunNabi requested a review from ermish December 4, 2024 01:46
@NabbeunNabi NabbeunNabi force-pushed the fix/remove-untranslated-swahili branch from b5b73e4 to d9dcfb6 Compare December 4, 2024 04:23
@NabbeunNabi NabbeunNabi force-pushed the fix/remove-untranslated-swahili branch from d9dcfb6 to 14d4a4f Compare December 4, 2024 04:35
Copy link
Contributor

@ermish ermish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shift it!

@ermish ermish merged commit ec21931 into main Dec 4, 2024
11 checks passed
@ermish ermish deleted the fix/remove-untranslated-swahili branch December 4, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove untranslated Swahili from dropdown options for language selection
3 participants