-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Add function to retrieve regressor coefficients #1597
base: main
Are you sure you want to change the base?
[Minor] Add function to retrieve regressor coefficients #1597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Constantin!
It is looking good overall!
You are headed in the right direction - I added some comments on how you can address some issues regarding the coefficient computation.
Please also add one or more tests covering your new functionality, a micro example in the docstring, and add a short feature-guide notebook demonstrating the use of your method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for upgrading the coefficient computation!
I left few small comments in the review. Beyond, Do you mind adding:
- Please also add one or more tests covering your new functionality,
- a micro example in the docstring,
- and add a short feature-guide notebook demonstrating the use of your method (both directly, and indirectly via the plotting methods).
- Please also look into the existing plotting code and make sure that that code uses your code for visualizing coefficients in plots. Please also make sure that if your code yields different results (compared to the existing plotting code; likely), that those differences are intentional/meaningful (also likely).
Thanks for the feedback! I wasn't aware that some of the weight calculations were already available and used in the plotting function. I adapted the functions to integrate cleaner with the existing code. |
🔬 Background
🔮 Key changes
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.