Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch lightning 2 ProgressBar class rename #1614

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

Joseph-Sarsfield
Copy link
Contributor

🔬 Background

  • pytorch lightning 2 ProgressBarBase class renamed to ProgressBar

🔮 Key changes

  • Explain the main changes introduced by this pull request for the reviewer.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@Joseph-Sarsfield
Copy link
Contributor Author

Joseph-Sarsfield commented Jul 17, 2024

Hi @ourownstory, please review fix for pytorch lightning 2.0

Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MaiBe-ctrl MaiBe-ctrl merged commit b8a1f59 into ourownstory:main Jul 26, 2024
8 of 10 checks passed
Copy link

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 30.8317 30.8317 0.0%
AirPassengers RMSE_val 31.8177 31.8177 0.0%
AirPassengers Loss_val 0.01301 0.01301 0.0%
AirPassengers train_loss 0.00071 0.00071 0.0%
AirPassengers reg_loss 0 0 0.0%
AirPassengers MAE 6.88164 6.88164 0.0%
AirPassengers RMSE 8.92097 8.92097 0.0%
AirPassengers Loss 0.00076 0.00076 0.0%
AirPassengers time 17.7358 17.54 -1.1%
EnergyPriceDaily MAE_val 5.64183 5.64183 0.0%
EnergyPriceDaily RMSE_val 7.19915 7.19915 0.0%
EnergyPriceDaily Loss_val 0.02893 0.02893 0.0%
EnergyPriceDaily train_loss 0.02957 0.02957 0.0%
EnergyPriceDaily reg_loss 0 0 0.0%
EnergyPriceDaily MAE 6.39657 6.39657 0.0%
EnergyPriceDaily RMSE 8.56213 8.56213 0.0%
EnergyPriceDaily Loss 0.02936 0.02936 0.0%
EnergyPriceDaily time 90.6251 87.71 -3.22%
YosemiteTemps MAE_val 0.59751 0.59751 0.0%
YosemiteTemps RMSE_val 0.88859 0.88859 0.0%
YosemiteTemps Loss_val 0.00046 0.00046 0.0%
YosemiteTemps train_loss 0.00126 0.00126 0.0%
YosemiteTemps reg_loss 0 0 0.0%
YosemiteTemps MAE 0.97464 0.97464 0.0%
YosemiteTemps RMSE 1.70813 1.70813 0.0%
YosemiteTemps Loss 0.00126 0.00126 0.0%
YosemiteTemps time 345.163 337.05 -2.35%
PeytonManning MAE_val 0.35542 0.35542 0.0%
PeytonManning RMSE_val 0.50403 0.50403 0.0%
PeytonManning Loss_val 0.01803 0.01803 0.0%
PeytonManning train_loss 0.01466 0.01466 0.0%
PeytonManning reg_loss 0 0 0.0%
PeytonManning MAE 0.34755 0.34755 0.0%
PeytonManning RMSE 0.49449 0.49449 0.0%
PeytonManning Loss 0.01465 0.01465 0.0%
PeytonManning time 104.886 103 -1.8%
\nModel training plots\n ## Model Training ### PeytonManning ![](https://asset.cml.dev/a20f3229a0e66a8df191473b928ce912684d93f9?cml=svg%2Bxml&cache-bypass=e667a785-0e8b-44b4-a5e7-15f12950375e) ### YosemiteTemps ![](https://asset.cml.dev/ad0a28634bb5c49472eb7aae3b902365b6bd906b?cml=svg%2Bxml&cache-bypass=0a2ea360-8ae0-4aa8-9fe3-b9ae46f3aed4) ### AirPassengers ![](https://asset.cml.dev/876b455cc505e11691bd1bc47008cf3dcc44e27e?cml=svg%2Bxml&cache-bypass=683a6d66-f2ea-4f9f-9f0e-d834afe25c55) ### EnergyPriceDaily ![](https://asset.cml.dev/6150802ffff58e2820d1da027c80e6f648b1a4ee?cml=svg%2Bxml&cache-bypass=614bb5f5-6b17-4853-b165-8f12700c76b9) \n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants