Connection constructor named object #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously for classes that implemented
Connection
interface, eachconstructor
could have it's own custom arguments needed to fulfill it's classes usage. When you list out the arguments when constructing a new instance of it you would have to know what argument goes in what order, and the arguments differ per Connection class.This change makes it so each Connection constructor now takes an object that has a type associated to it so you can see what the values required are.
Resolves #10
Tasks
OuterbaseConnection
constructor to support aOuterbaseConnectionDetails
type in the constructorCloudflareD1Connection
constructor to support aCloudflareD1ConnectionDetails
type in the constructorVerify
Before
After