fix: Image caption empty after pasting

outline · Nov 13, 2020 · 1a9a262 · 1a9a262
1 parent a3762d6
commit 1a9a262
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/src/nodes/CheckboxItem.ts b/src/nodes/CheckboxItem.ts
@@ -23,7 +23,7 @@ export default class CheckboxItem extends Node {
       parseDOM: [
         {
           tag: `li[data-type="${this.name}"]`,
-          getAttrs: dom => ({
+          getAttrs: (dom: HTMLLIElement) => ({
             checked: dom.className.includes("checked"),
           }),
         },

diff --git a/src/nodes/CodeFence.ts b/src/nodes/CodeFence.ts
@@ -64,9 +64,9 @@ export default class CodeFence extends Node {
           tag: ".code-block",
           preserveWhitespace: "full",
           contentElement: "code",
-          getAttrs: node => {
+          getAttrs: (dom: HTMLDivElement) => {
             return {
-              language: node.dataset.language,
+              language: dom.dataset.language,
             };
           },
         },

diff --git a/src/nodes/Image.tsx b/src/nodes/Image.tsx
@@ -111,13 +111,12 @@ export default class Image extends Node {
       parseDOM: [
         {
           tag: "div[class=image]",
-          getAttrs: (dom: HTMLElement) => {
+          getAttrs: (dom: HTMLDivElement) => {
             const img = dom.getElementsByTagName("img")[0];
-            const caption = dom.getElementsByTagName("p")[0];
 
             return {
               src: img.getAttribute("src"),
-              alt: caption.innerText,
+              alt: img.getAttribute("alt"),
             };
           },
         },

diff --git a/src/nodes/Notice.tsx b/src/nodes/Notice.tsx
@@ -34,7 +34,7 @@ export default class Notice extends Node {
           tag: "div.notice-block",
           preserveWhitespace: "full",
           contentElement: "div:last-child",
-          getAttrs: dom => ({
+          getAttrs: (dom: HTMLDivElement) => ({
             style: dom.className.includes("tip")
               ? "tip"
               : dom.className.includes("warning")

diff --git a/src/nodes/OrderedList.ts b/src/nodes/OrderedList.ts
@@ -19,7 +19,7 @@ export default class OrderedList extends Node {
       parseDOM: [
         {
           tag: "ol",
-          getAttrs: (dom: HTMLElement) => ({
+          getAttrs: (dom: HTMLOListElement) => ({
             order: dom.hasAttribute("start")
               ? parseInt(dom.getAttribute("start") || "1", 10)
               : 1,