Skip to content

🔥 refactor: Merge --plain and --msword option into new one --style [msword,plain] #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

🔥 refactor: Merge --plain and --msword option into new one --style [msword,plain] #26

wants to merge 6 commits into from

Conversation

@emmanuel-quevillon-outscale
Copy link
Contributor

@emmanuel-quevillon-outscale emmanuel-quevillon-outscale commented Sep 15, 2025 •
edited
Loading

It solve also option precedence when using both options on the command line as shown below:

➜  oks-cli cluster list --plain --msword
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   2 days ago  |   2 days ago  |   ready    |         |

~/work/src/oks-stuffs/cluster-api via 🐍 v3.13.5 (.venv-oks-cli)
➜  oks-cli cluster list --msword --plain
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   2 days ago  |   2 days ago  |   ready    |         |

As shown and based on the conditions in the code, it's always --msword option that wins. Introducing --style option, this behaviour won't happen anymore.
Style --msword and --plain options are supported, but deprecated with a Warning message as shown below:

 ➜  oks-cli cluster list --plain 
DeprecationWarning: The option 'plain' is deprecated. Use --style instead
+-----------------------+---------------+---------------+------------+---------+
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
+-----------------------+---------------+---------------+------------+---------+
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   3 days ago  |   3 days ago  |   ready    |         |
+-----------------------+---------------+---------------+------------+---------+

➜  oks-cli cluster list --msword      
DeprecationWarning: The option 'msword' is deprecated. Use --style instead
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   3 days ago  |   3 days ago  |   ready    |         |

➜  oks-cli cluster list --style plain   
         NAME                   CREATED              UPDATED             STATUS          DEFAULT        
clusterapi-management         11 days ago          11 days ago           ready                          
  anotherclusterapi            3 days ago           3 days ago           ready                    

➜  oks-cli cluster list --style msword
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   3 days ago  |   3 days ago  |   ready    |         |

In the case of multiple time option --style, the last one is considered

➜  oks-cli cluster list --style msword --style plain --style msword
|          NAME         |    CREATED    |    UPDATED    |   STATUS   | DEFAULT |
| clusterapi-management |  11 days ago  |  11 days ago  |   ready    |         |
|   anotherclusterapi   |   3 days ago  |   3 days ago  |   ready    |         |

@emmanuel-quevillon-outscale
🔥 refactor: Merge --plain and --msword option into new one --style [m…
8c44a69 
…sword,plain]. This allow to easily add new sytle if needed.

It solve also option precedence when using both option on the command line. See PR message.
@emmanuel-quevillon-outscale
Fix setting table style with cluster list command
fbd9fd3
@emmanuel-quevillon-outscale
🎨 refactor: Add multiple=False to --style option arguments
880b631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@outscale-rde outscale-rde Awaiting requested review from outscale-rde

@outscale-ykr outscale-ykr Awaiting requested review from outscale-ykr

@outscale-rce outscale-rce Awaiting requested review from outscale-rce

@anton-kutin anton-kutin Awaiting requested review from anton-kutin anton-kutin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmanuel-quevillon-outscale @outscale-ykr