Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

Commit

Permalink
rename Sink.createSink to Sink.create
Browse files Browse the repository at this point in the history
  • Loading branch information
Luka Jacobowitz committed Mar 8, 2017
1 parent ecaf7f2 commit 3794050
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions src/Sink.purs
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ foreign import createHandlerImpl :: forall a e. Array a -> Handler e a
createHandler :: forall a e. Array a -> Handler e a
createHandler = createHandlerImpl

createSink :: forall a e. (a -> Eff e Unit) -> Sink e a
createSink fn = { sink : Observer fn }
create :: forall a e. (a -> Eff e Unit) -> Sink e a
create fn = { sink : Observer fn }


foreign import redirect :: forall a b e r. SinkLike e a r -> (Observable b -> Observable a) -> Sink e b
Expand Down
2 changes: 1 addition & 1 deletion src/util/Store.purs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type Store eff state action =

createStore :: forall eff state action. state -> (action -> state -> state) -> Store eff state action
createStore initialState reducer =
let handler = createHandler []
let handler = createHandler[]
src = handler.src
# scan reducer initialState
# startWith initialState
Expand Down
12 changes: 6 additions & 6 deletions test/DomEventSpec.purs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import DOM.Node.ParentNode (childElementCount, querySelector)
import DOM.Node.Types (Document, Node, documentToParentNode, elementToEventTarget, elementToNode)
import Data.Array (length) as Array
import EmitterBuilder (mapE, override)
import OutWatch.Sink (createSink)
import OutWatch.Sink (create)
import Prelude (Unit, bind, const, map, not, pure, show, (#), ($), (==))
import RxJS.Observable (fromArray, just)
import Test.JsHelpers (newEvent)
Expand Down Expand Up @@ -60,7 +60,7 @@ domEventSuite =
test "The DOM Events Api should be able to emit events to a Sink" do
refFlag <- liftEff (newRef false)
liftEff createDomRoot
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
root = div [ click ==> sink ]
flagBeforeAll <- liftEff (readRef refFlag)
assert "Emitter shouldn't emit before rendering" (not flagBeforeAll)
Expand All @@ -79,8 +79,8 @@ domEventSuite =
refFlag <- liftEff (newRef false)
refFlag2 <- liftEff (newRef false)
liftEff createDomRoot
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
sink2 = createSink (\_ -> modifyRef refFlag2 (\_ -> true))
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
sink2 = create (\_ -> modifyRef refFlag2 (\_ -> true))
root = div [ click ==> sink , click ==> sink2 ]
liftEff (render "#app" root)
doc <- liftEff getDocument
Expand All @@ -96,7 +96,7 @@ domEventSuite =
test "Event emitters should be able to have their values mapped" do
refFlag <- liftEff (newRef false)
liftEff createDomRoot
let sink = createSink (\b -> modifyRef refFlag (\_ -> b))
let sink = create (\b -> modifyRef refFlag (\_ -> b))
root = div [ mapE click (const true) ==> sink ]
liftEff (render "#app" root)
doc <- liftEff getDocument
Expand All @@ -110,7 +110,7 @@ domEventSuite =
test "Event emitters should be able to have their values overriden by another Observable" do
refFlag <- liftEff (newRef false)
liftEff createDomRoot
let sink = createSink (\b -> modifyRef refFlag (\_ -> b))
let sink = create (\b -> modifyRef refFlag (\_ -> b))
stream = just true
root = div [ override click stream ==> sink ]
liftEff (render "#app" root)
Expand Down
8 changes: 4 additions & 4 deletions test/LifecycleHookSpec.purs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import DOM.Node.Element (setAttribute)
import DOM.Node.Node (appendChild, setTextContent)
import DOM.Node.Types (Node, elementToNode)
import Data.Unit (Unit)
import OutWatch.Sink (createSink)
import OutWatch.Sink (create)
import Prelude (bind, not)
import RxJS.Observable (fromArray)
import Test.Unit (TestSuite, suite, test)
Expand All @@ -34,7 +34,7 @@ lifecycleHookSuite =
test "insertion hooks should be called when a VNode is inserted" do
refFlag <- liftEff (newRef false)
liftEff createDomRoot
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
root = div [ insert ==> sink ]
flagBeforeRendering <- liftEff (readRef refFlag)
assert "Insert hook shouldn't be called before rendering" (not flagBeforeRendering)
Expand All @@ -45,7 +45,7 @@ lifecycleHookSuite =
test "destruction hooks should be called when a VNode is destroyed" do
refFlag <- liftEff (newRef false)
liftEff createDomRoot
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
innerChild = fromArray [ span [ destroy ==> sink ], h3 [] ]
root = div [ child <== innerChild ]
flagBeforeRendering <- liftEff (readRef refFlag)
Expand All @@ -57,7 +57,7 @@ lifecycleHookSuite =
test "update hooks should be called when a VNode is updated" do
refFlag <- liftEff (newRef false)
liftEff createDomRoot
let sink = createSink (\_ -> modifyRef refFlag (\_ -> true))
let sink = create (\_ -> modifyRef refFlag (\_ -> true))
innerChild = fromArray [ span [ update ==> sink, text "First" ], span [ update ==> sink , text "second" ] ]
root = div [ child <== innerChild ]
flagBeforeRendering <- liftEff (readRef refFlag)
Expand Down

0 comments on commit 3794050

Please sign in to comment.