Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the old style delayed_job delivery to ActiveJob delivery #45

Open
oveits opened this issue Mar 1, 2016 · 0 comments
Open

Migrate the old style delayed_job delivery to ActiveJob delivery #45

oveits opened this issue Mar 1, 2016 · 0 comments

Comments

@oveits
Copy link
Owner

oveits commented Mar 1, 2016

In the moment, I am running two different approaches for delivering background jobs:

  1. provision, delete/de-provision and read are performed via old style Provisioning.deliver method, which directly calls delayed_jobs.
  2. synchronize is performed via new style GeneralJob.perform_later(...) method. The Provisioning model is used only for persistently saving the job to the database for later reference. Provisioning's deliver method is not called.

I need to find a one method fits all solution. Two possibilities:

A) Migrate old style to new style
B) change new style: e.g. call GeneralJob.perform_later within the Provisioning.deliver method (might be the better choice? This is to be discussed).

TODO:

  1. Find best solution between A) and B) above.
  2. Work on GeneralJob+Provisioning model cleaning topics like follows:
  • recording of the number of attempts in Provisioning model
  • link to delayed_job to be replaced by link to GeneralJob in Provisioning model.

The change is non-functional only with no impact on the service, so the prio could be set to low. However, it needs to be done in order to keep the code maintenable. Therefore, I raise it to normal prio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant