Migrate Windows build from Cygwin to vcpkg and add ASAN support #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modernizes the Windows build system by migrating from Cygwin-based dependency management to vcpkg, Microsoft's official C++ package manager. The changes eliminate external dependencies while adding comprehensive AddressSanitizer support. Key improvements: - New vcpkg-based build script (windows-release-vcpkg.ps1) - Automatic ICU dependency management via vcpkg - Enhanced CI/CD pipeline with ASAN build configuration - Simplified developer setup without Cygwin requirements - Better Visual Studio 2022 toolchain integration 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Dynamically detect LLVM/Clang ASAN library path - Set environment variables for linker to find ASAN runtime - Skip CMake compiler test which fails with ASAN flags - Add proper ASAN library path to linker flags - Works with scoop, chocolatey, or VS-installed LLVM
- Remove individual package installation (icu:x64-windows) - Use vcpkg install without arguments to install from vcpkg.json - Add proper error handling for manifest mode - Fix CI build failure
- ASAN now always builds in Release mode for best performance - Removed ASAN-Debug configuration as per request - Clang ASAN doesn't fully support debug runtime anyway - Cleaner, simpler configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request modernizes the Windows build system for the Bun WebKit fork by migrating from the legacy Cygwin-based dependency management to vcpkg, Microsoft's official C++ package manager. The changes eliminate external dependencies while adding comprehensive AddressSanitizer (ASAN) support for Windows development.
Key Changes
1. Vcpkg Integration
windows-release-vcpkg.ps1- Modern PowerShell-based build system2. AddressSanitizer Support
-Configuration ASANbuild option/fsanitize=addressflag integration/MD) for ASAN compatibility3. CI/CD Improvements
Benefits
Development Experience
Maintenance
Testing Completed
Build Configurations Tested
Cross-Platform Compatibility
Files Modified
New Files
windows-release-vcpkg.ps1: Modern build script with vcpkg integrationPR_NOTES.md: Documentation fileModified Files
.github/workflows/build.yml: Updated CI pipeline for new build configurations🤖 Generated with Claude Code