bun pm pack support files starting with ./

oven-sh · Feb 7, 2025 · fd06bee · fd06bee
1 parent c970922
commit fd06bee
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/src/cli/pack_command.zig b/src/cli/pack_command.zig
@@ -2129,6 +2129,12 @@ pub const PackCommand = struct {
                     @"has leading **/, (could start with '!')" = true;
                 }
 
+                // `./foo` matches the same as `foo`
+                if (strings.hasPrefixComptime(remain, "./")) {
+                    remain = remain["./".len..];
+                    if (remain.len == 0) return null;
+                }
+
                 const trailing_slash = remain[remain.len - 1] == '/';
                 if (trailing_slash) {
                     // trim trailing slash

diff --git a/test/cli/install/bun-pack.test.ts b/test/cli/install/bun-pack.test.ts
@@ -921,7 +921,7 @@ describe("files", () => {
       write(
         join(packageDir, "package.json"),
         JSON.stringify({
-          name: "pack-files-3",
+          name: "pack-files-2",
           version: "1.2.3",
           files: ["index.js"],
         }),
@@ -932,16 +932,34 @@ describe("files", () => {
     ]);
 
     await pack(packageDir, bunEnv);
-    const tarball = readTarball(join(packageDir, "pack-files-3-1.2.3.tgz"));
+    const tarball = readTarball(join(packageDir, "pack-files-2-1.2.3.tgz"));
     expect(tarball.entries).toMatchObject([{ "pathname": "package/package.json" }, { "pathname": "package/index.js" }]);
   });
 
+  test("matches './' as the root", async () => {
+    await Promise.all([
+      write(
+        join(packageDir, "package.json"),
+        JSON.stringify({
+          name: "pack-files-3",
+          version: "1.2.3",
+          files: ["./dist"],
+        }),
+      ),
+      write(join(packageDir, "dist", "index.js"), "console.log('hello ./dist/index.js')"),
+    ]);
+
+    await pack(packageDir, bunEnv);
+    const tarball = readTarball(join(packageDir, "pack-files-3-1.2.3.tgz"));
+    expect(tarball.entries).toMatchObject([{ "pathname": "package/package.json" }, { "pathname": "package/dist/index.js" }]);
+  });
+
   test("recursive only if leading **/", async () => {
     await Promise.all([
       write(
         join(packageDir, "package.json"),
         JSON.stringify({
-          name: "pack-files-2",
+          name: "pack-files-4",
           version: "1.2.123",
           files: ["**/index.js"],
         }),
@@ -953,7 +971,7 @@ describe("files", () => {
     ]);
 
     await pack(packageDir, bunEnv);
-    const tarball = readTarball(join(packageDir, "pack-files-2-1.2.123.tgz"));
+    const tarball = readTarball(join(packageDir, "pack-files-4-1.2.123.tgz"));
     expect(tarball.entries).toMatchObject([
       { "pathname": "package/package.json" },
       { "pathname": "package/index.js" },