node:crypto: add blake2b512, sha512-224, sha3-* #10383
Conversation
|
The methods using |
| .evp => {}, | ||
| .zig => |*inner| { | ||
| inner.final(output_digest_slice); | ||
| return encoding.encodeWithMaxSize(globalThis, BoringSSL.EVP_MAX_MD_SIZE, output_digest_slice[0..inner.digest_length]); |
There was a problem hiding this comment.
BoringSSL.EVP_MAX_MD_SIZE should be a different value here right?
There was a problem hiding this comment.
BoringSSL.EVP_MAX_MD_SIZE is the max size of all digests, output_digest_slice is the size of the current digest
| return encoding.encodeWithMaxSize(globalThis, BoringSSL.EVP_MAX_MD_SIZE, output_digest_slice[0..inner.digest_length]); | ||
| }, | ||
| } | ||
|
|
||
| const out = this.evp.final(globalThis.bunVM().rareData().boringEngine(), output_digest_slice); |
There was a problem hiding this comment.
can this be moved into the .evp branch?:
There was a problem hiding this comment.
wanted to keep the diff small for the first iteration to make easier to review and test
| return thisValue; | ||
| }, | ||
| } | ||
|
|
||
| this.evp.update(buffer.slice()); |
There was a problem hiding this comment.
can you move this to .evp =>
There was a problem hiding this comment.
wanted to keep the diff small for the first iteration to make easier to review and test
Closes #4862