Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow connecting a socket again after its connection was closed #10781

Merged
merged 4 commits into from
May 3, 2024

Conversation

gvilums
Copy link
Contributor

@gvilums gvilums commented May 2, 2024

What does this PR do?

Allows a net.Socket to be re-used to connect and write data to another peer after the initial connection is terminated, matching node's behavior.
Fixes #7325

How did you verify your code works?

Added a test.

@Jarred-Sumner Jarred-Sumner merged commit ec6110e into main May 3, 2024
41 of 52 checks passed
@Jarred-Sumner Jarred-Sumner deleted the georgijs/net-reconnect branch May 3, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node::net.Socket() reusing socket works on NodeJS but fails in Bun
2 participants