Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update c-ares #11361

Merged
merged 2 commits into from
May 26, 2024
Merged

Update c-ares #11361

merged 2 commits into from
May 26, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Update c-ares

Maybe it'll fix the dns issue on windows

To get the latest headers, I ran:

zig translate-c -Isrc/deps/c-ares/include -Isrc/deps/c-ares/build src/deps/c-ares/include/ares.h

And then compared the extern struct we have in our partially generated bindings vs the ones from zig translate-c. The only one whose size seemed to change was the options struct.

How did you verify your code works?

Ran the tests locally

Copy link
Contributor

github-actions bot commented May 26, 2024

@Jarred-Sumner, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

  • test/js/bun/http/serve-body-leak.test.ts 1 failing

💻 3 failing tests Darwin x64

  • test/js/node/tls/node-tls-context.test.ts 1 failing
  • test/js/web/fetch/fetch.tls.test.ts 1 failing
  • test/js/web/workers/worker.test.ts 1 failing

🪟💻 6 failing tests Windows x64 baseline

  • test/cli/install/bunx.test.ts 1 failing
  • test/cli/install/migration/complex-workspace.test.ts 21 failing
  • test/js/bun/http/serve-body-leak.test.ts 1 failing
  • test/js/node/http/node-http.test.ts 1 failing
  • test/js/node/process/process.test.js 2 failing
  • test/js/node/watch/fs.watchFile.test.ts 3 failing

🪟💻 5 failing tests Windows x64

  • test/cli/install/bunx.test.ts 1 failing
  • test/js/bun/http/serve-body-leak.test.ts 1 failing
  • test/js/node/http/node-http.test.ts 1 failing
  • test/js/node/process/process.test.js 2 failing
  • test/js/node/watch/fs.watchFile.test.ts SIGKILL

View logs

@Jarred-Sumner Jarred-Sumner merged commit 59bbedf into main May 26, 2024
49 of 53 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/update-cares branch May 26, 2024 04:36
paperclover pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant