Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: add JSValue assertion to cppFn #15445

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

zig: add JSValue assertion to cppFn #15445

wants to merge 1 commit into from

Conversation

nektro
Copy link
Member

@nektro nektro commented Nov 27, 2024

progress towards #15141
followup/similar to #15362

@robobun
Copy link

robobun commented Nov 27, 2024

@nektro, your commit dff4ae9 has 20 failures in #6977:

  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/timers-ordering.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/bun/http/serve.test.ts - SIGTRAP on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/bake/dev/esm.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/third_party/jsonwebtoken/header-kid.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/third_party/jsonwebtoken/header-kid.test.js - internal assertion failure on 🪟 2019 x64
  • test/js/node/test/parallel/http-date-header.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/http-date-header.test.js - internal assertion failure on 🪟 2019 x64
  • test/js/third_party/jsonwebtoken/claim-private.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/third_party/jsonwebtoken/claim-private.test.js - internal assertion failure on 🪟 2019 x64
  • test/js/bun/dns/resolve-dns.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/process-constants-noatime.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/process-constants-noatime.test.js - internal assertion failure on 🪟 2019 x64
  • test/js/third_party/jsonwebtoken/claim-aud.test.js - internal assertion failure on 🪟 2019 x64
  • test/js/third_party/jsonwebtoken/claim-aud.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/bun/test/expect.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/bun/test/expect.test.js - internal assertion failure on 🪟 2019 x64
  • test/js/node/test/parallel/http2-compat-serverresponse-headers-send-date.test.js - internal assertion failure on 🪟 2019 x64
  • test/js/node/test/parallel/http2-compat-serverresponse-headers-send-date.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/bun/ffi/ffi.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/bun/ffi/ffi.test.js - internal assertion failure on 🪟 2019 x64
  • test/js/third_party/jsonwebtoken/async_sign.test.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/third_party/jsonwebtoken/async_sign.test.js - internal assertion failure on 🪟 2019 x64
  • @Jarred-Sumner
    Copy link
    Collaborator

    Fancy, but this adds many duplicate exception checks. Can we avoid duplicate exception checks?

    @nektro
    Copy link
    Member Author

    nektro commented Nov 27, 2024

    per-irl discussion
    .get uses a manual extern fn so this doesn't overlap there
    callsite checks are 100% due for audit/removal/rewrite
    previous pr adds check at different boundary so there's no overlap there

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants