Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip root scripts if root is filtered out with --filter #16152

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

dylan-conway
Copy link
Member

What does this PR do?

How did you verify your code works?

Added a test.

@robobun
Copy link

robobun commented Jan 4, 2025

Updated 1:28 AM PT - Jan 4th, 2025

@Jarred-Sumner, your commit 917e982 has 2 failures in #8946:


🧪   try this PR locally:

bunx bun-pr 16152

@@ -15027,11 +15028,60 @@ pub const PackageManager = struct {
return;
}

var path_buf: bun.PathBuffer = undefined;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Jarred-Sumner Jarred-Sumner merged commit 79aa5d1 into main Jan 4, 2025
66 of 67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/skip-root-scripts branch January 4, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants