hot module reloading for HTML import development mode #16955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 10:40 PM PT - Feb 7th, 2025
❌ @paperclover, your commit d2771a1 has 2 failures in
🧪 try this PR locally: bunx bun-pr 16955 |
paperclover
changed the title
| @@ -10,8 +10,8 @@ | |||
| "@typescript-eslint/eslint-plugin": "^7.11.0", | |||
| "@typescript-eslint/parser": "^7.11.0", | |||
| "@vscode/debugadapter": "^1.65.0", | |||
| "autoprefixer": "^10.4.20", | |||
| "caniuse-lite": "^1.0.30001660", | |||
| "autoprefixer": "^10.4.19", | |||
|
|
||
| if (bun.FeatureFlags.bake_debugging_features and dev.has_pre_crash_handler) | ||
| try bun.crash_handler.appendPreCrashHandler(DevServer, dev, dumpStateDueToCrash); | ||
|
|
||
| return dev; | ||
| } | ||
|
|
||
| pub fn deinit(dev: *DevServer) void { | ||
| // TODO: Currently deinit is not implemented, as it was assumed to be alive for | ||
| // the remainder of this process' lifespan. This isn't always true. |
There was a problem hiding this comment.
is especially not true now that server.stop() can make this happen
| } | ||
|
|
||
| fn memoryCostArrayList(slice: anytype) usize { | ||
| return slice.capacity * @sizeOf(@typeInfo(@TypeOf(slice.items)).pointer.child); |
There was a problem hiding this comment.
imo this is too clever it can just use allocatedSlice() or one of those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16335
DevServer gains a new type of RouteBundle for HTML imports. HTML imports have no server files, but may co-exist alongside server routes. While only SPA-style apps are supported now, the tech supports RSC in the same graph as these HTML route bundles.
Instead of
framework: "react", the framework option is currently unspecifiable. To allow React to 'just work', the default framework will automatically configurereact-refreshif it is installed. If onlyreactis installed, then an embedded copy ofreact-refreshis enabled to make that also 'just work'.This PR also resolves some but not all requirements to use HMR reliably, so I still call it experimental. It is very close though.