Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick fix for building bun with LLVM 21 #17070

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

quick fix for building bun with LLVM 21 #17070

wants to merge 4 commits into from
+13 −13

Conversation

zimirza
Copy link

@zimirza zimirza commented Feb 5, 2025 •
edited
Loading

What does this PR do?

This is a quick fix for making bun to build with LLVM 21.

How did you verify your code works?

$ git clone https://github.com/oven-sh/bun.git
$ cd bun
$ bun run build:debug

Closes #17069

@zimirza zimirza changed the title quick fix for building bun on gentoo quick fix for building bun on LLVM 21 Feb 5, 2025
@zimirza zimirza changed the title quick fix for building bun on LLVM 21 quick fix for building bun with LLVM 21 Feb 5, 2025
@zimirza zimirza force-pushed the bun_build_v8_bindings_17069 branch 2 times, most recently from 92eaab5 to 440fc06 Compare February 5, 2025 10:46
@zimirza zimirza force-pushed the bun_build_v8_bindings_17069 branch from 440fc06 to 0bb6d0b Compare February 5, 2025 10:46
paperclover
paperclover requested changes Feb 8, 2025
View reviewed changes
Copy link
Member

@paperclover paperclover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead, can you just remove the unused variables?

@zimirza
Copy link
Author

zimirza commented Feb 8, 2025

Sure, I can remove the unused variables. I actually thought it was not finished implemented.

@zimirza zimirza marked this pull request as draft February 8, 2025 17:54
@zimirza zimirza marked this pull request as ready for review February 9, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paperclover paperclover paperclover requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiling with LLVM 21 seems to fail on unused variables for V8 bindings
2 participants
@zimirza @paperclover