Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node/net): better BlockList shim #17116

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Feb 6, 2025

What does this PR do?

Improves net.BlockList. Not a full implementation, but all methods now exist.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test-file-name.test)

@robobun
Copy link

robobun commented Feb 6, 2025

Updated 1:18 PM PT - Feb 7th, 2025

@DonIsaac, your commit adc431e has 2 failures in Build #11268:


🧪   try this PR locally:

bunx bun-pr 17116

@DonIsaac DonIsaac requested review from a team and zackradisic and removed request for a team February 7, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants