fix(table): Respect falsy value for addDuplicateNumbers #672
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for the third parameter (
addDuplicateNumbers
) does not respect a falsy value.When a value of
false
is passed the logic is resolved as follows:addDuplicateNumbers ~= nil
resolves totrue
addDuplicateNumbers ~= nil and addDuplicateNumbers
is therefore the same astrue and false
which resolves tofalse
addDuplicateNumbers ~= nil and addDuplicateNumbers or true
is therefore the same afalse or true
, which resolves totrue
So a falsy value always coerces to
true
.Simple test script:
Proposed solution is to reverse the logic somewhat so it sets the value to
true
only whennil
.Running the same test script: