Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(marker): logical error when setting faceCamera #686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NotSomething0
Copy link

Due to the way boolean values were being assigned, faceCamera would always evaluate to true because of its default value. This change fixes the logical error and ensures boolean properties are properly set.

@jag3dagster
Copy link
Member

jag3dagster commented Jan 16, 2025

This looks like a similar logic error as #672. Could you update your logic to match the formatting of the feedback in that PR with a single line instead of these additional if blocks please?

@NotSomething0
Copy link
Author

NotSomething0 commented Jan 16, 2025

Updated, I left the boolean check instead of just checking for nil since DrawMarker expects a boolean and the game doesn't care what you pass as a truthy value as long as it isn't nil, 0 or false.

Due to the way boolean values were being assigned, faceCamera would
always evaluate to true because of its default value. This change fixes
the logical error and ensures boolean properties are properly set.
Copy link
Member

@jag3dagster jag3dagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @thelindat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants