Fix(connection/raw query) handle promise when db connection lost #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently developping a gta fivem resource where it could use oxmysql optionnally so I need to check if the database is available or not even after the oxmysql resource is started.
Currently oxmysql do not check if the database is still available after the start while for any reason, the connection can be lost.
Following my tests, I got a promise error not managed which cannot let us handle this case :
After my analysis of your code, I found a quick fix for that which result of this with the test code after:
Here my sample code for testing db connection :
I don't have a full vision of impact which could happens for other resources so feel free to suggest/review my fix.
Maybe a method to test the real current status of database connection could be great and not only trusting local state.