Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Testing and Linting #54

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Feat: Testing and Linting #54

merged 6 commits into from
Nov 24, 2023

Conversation

CodeWithEmad
Copy link
Member

@CodeWithEmad CodeWithEmad commented Nov 18, 2023 •
edited
Loading

Assorted testing and linting improvements:

  • Makefile with test and lint targets
  • Long lines reformated with black
  • Sort imports with isort

In addition:

  • Typing added for various functions

@CodeWithEmad CodeWithEmad mentioned this pull request Nov 18, 2023
Closed
@Faraz32123
Copy link
Collaborator

Hi @CodeWithEmad, thanks for the PR.
can u please resolve the merge conflicts.

@CodeWithEmad
Copy link
Member Author

Done.

Faraz32123
Faraz32123 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@Faraz32123 Faraz32123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Faraz32123 Faraz32123 merged commit 0d9eb05 into overhangio:master Nov 24, 2023
1 check passed
@CodeWithEmad CodeWithEmad deleted the feat/test-lint branch November 24, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faraz32123 Faraz32123 Faraz32123 approved these changes

Assignees

@Faraz32123 Faraz32123

Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeWithEmad @Faraz32123