Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create media directory in Dockerfile. #70

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

angonz
Copy link
Contributor

@angonz angonz commented Apr 12, 2024

If the media directory does not exist at the time that uwsgi is launched, the mapping to /media to serve
media files will not be created.

See issue #69

@Faraz32123
Copy link
Collaborator

@angonz thanks for bearing it with me. Issue reproduced and was fixed with the patch in Dockerfile.
Please change the changelog entry to below text only and remove the comment So that I can merge the change.

  • [Bugfix] Fix the docker image to allow media files to be served by uwsgi. (by @angonz)

If the media directory does not exist at the time that
uwsgi is launched, the mapping to /media to serve
media files will not be created.
Copy link
Collaborator

@Faraz32123 Faraz32123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Faraz32123 Faraz32123 merged commit ecff88e into overhangio:master Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants