Skip to content

Commit

Permalink
feat: don't override imagepullpolicy on k8s
Browse files Browse the repository at this point in the history
We should use the default cluster value for imagePullPolicy. This makes
it easier to run the MFE with Minikube:
https://minikube.sigs.k8s.io/docs/handbook/pushing/

> Tip 1: Remember to turn off the imagePullPolicy:Always (use
> imagePullPolicy:IfNotPresent or imagePullPolicy:Never) in your yaml
> file. Otherwise Kubernetes won’t use your locally build image and it
> will pull from the network.
  • Loading branch information
regisb committed Aug 3, 2023
1 parent 2b305f1 commit 8522ab6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/20230627_162842_regis.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Improvement] Don't override `imagePullPolicy` in Kubernetes. This was only necessary in older releases. (by @regisb)
1 change: 0 additions & 1 deletion tutormfe/patches/k8s-deployments
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ spec:
containers:
- name: mfe
image: {{ MFE_DOCKER_IMAGE }}
imagePullPolicy: Always
ports:
- containerPort: 8002
volumeMounts:
Expand Down

0 comments on commit 8522ab6

Please sign in to comment.